Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(InputMenu/SelectMenu): allow lazy search #1705

Merged
merged 6 commits into from
Apr 26, 2024
Merged

feat(InputMenu/SelectMenu): allow lazy search #1705

merged 6 commits into from
Apr 26, 2024

Conversation

YIngChenIt
Copy link
Contributor

@YIngChenIt YIngChenIt commented Apr 23, 2024 •
edited

🔗 Linked issue

Resolves #1686

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Maybe we need a searchableLazy switch to achieve optimization goals.

Use the searchableLazy prop to control the immediacy of data requests.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@SedanaYoga
Copy link
Contributor

Hey @benjamincanac hope you're good!
Could you please check this PR? and please let us know the ETA, thanks :)

@benjamincanac
Copy link
Member

Would you mind do the same for the InputMenu? 😊

@YIngChenIt
Copy link
Contributor Author

Would you mind do the same for the InputMenu? 😊

It's already done

@benjamincanac benjamincanac changed the title chore(selectMenu): Add searchableLazy prop to SelectMenu component feat(SelectMenu/InputMenu): handle lazy search Apr 26, 2024
@benjamincanac benjamincanac changed the title feat(SelectMenu/InputMenu): handle lazy search feat(InputMenu/SelectMenu): handle lazy search Apr 26, 2024
@benjamincanac benjamincanac changed the title feat(InputMenu/SelectMenu): handle lazy search feat(InputMenu/SelectMenu): allow lazy search Apr 26, 2024
@benjamincanac benjamincanac merged commit 7e6ba78 into nuxt:dev Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SelectMenu] Able to prevent fetching before clicking
3 participants
@YIngChenIt @SedanaYoga @benjamincanac