Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow disabling cache with NUXT_CACHE_DISABLED flag #628

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

styfle
Copy link
Contributor

@styfle styfle commented Sep 20, 2021

The cache directory is caching files with absolute paths causing deployments with multiple builds to occasionally fail if they complete in a different order than the previous build.

This PR adds a flag to disable caching until the proper fix can be found.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you! ❤️

@danielroe
Copy link
Member

@styfle Could you explain a bit more about the issue - is the issue that the files are cached with absolute path, or is it that the contents of some of the files contain absolute paths? (It would be good to solve underlying issue.)

@styfle
Copy link
Contributor Author

styfle commented Sep 23, 2021

I believe the contents of some of the cached files contain absolute paths.

@danielroe
Copy link
Member

@styfle Thanks! Would be good to open an issue on the relevant module and we can remedy that issue there too 👍.

@danielroe danielroe changed the title Add NUXT_CACHE_DISABLED flag feat: allow disabling cache with NUXT_CACHE_DISABLED flag Sep 23, 2021
@danielroe danielroe merged commit e993410 into nuxt:main Sep 23, 2021
@styfle styfle deleted the patch-1 branch September 23, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants