fix: meta content templates #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 34 34
Lines 534 547 +13
Branches 149 153 +4
=====================================
+ Hits 534 547 +13
Continue to review full report at Codecov.
|
manniL
reviewed
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both in v1 as in v2 the meta content templates caused wrong content if you would eg run the exact same tests multiple times. This was mainly caused by the fact that templates where removed once used so if both parent and child had templates defined on the second run the other template would be used.
So instead of explicitly removing templates we now keep track if a template has been applied for that specific meta property by setting template to true so a template is never applied twice (this was found in #426).
This fix could potentially break advanced configs like eg chained templates through multiple components though (but not sure if that was even possible, never tried it), but I think its better to support basic functionality as in 426 then advanced configs for now.