Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): colspan of empty and loading is wrong when selection enabled #284

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

9uenther
Copy link
Contributor

If you use the selection, the number of columns of the empty and loading slot is wrong.

fix(table): with the selection, the number of columns is wrong
@vercel
Copy link

vercel bot commented Jun 13, 2023

@9uenther is attempting to deploy a commit to the Nuxt Labs Team on Vercel.

A member of the Team first needs to authorize it.

@benjamincanac benjamincanac changed the title fix (table) - colspan of empty and loading is wrong with the selection fix(Table) colspan of empty and loading is wrong when selection enabled Jun 13, 2023
@benjamincanac benjamincanac changed the title fix(Table) colspan of empty and loading is wrong when selection enabled fix(Table): colspan of empty and loading is wrong when selection enabled Jun 13, 2023
@benjamincanac benjamincanac changed the title fix(Table): colspan of empty and loading is wrong when selection enabled fix(Table): colspan of empty and loading is wrong when selection enabled Jun 13, 2023
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, shouldn't the condition be the same as <th v-if="modelValue"> on modelValue?

@9uenther
Copy link
Contributor Author

You're right, that would be the same

@benjamincanac benjamincanac merged commit 786d776 into nuxt:dev Jun 13, 2023
1 check failed
@benjamincanac
Copy link
Member

Thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants