Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build error - comparison to zero in scalar_unary_red_omp.cc - both g++ and clang++ #84

Closed
shivsundram opened this issue Aug 25, 2021 · 5 comments
Closed

Build error - comparison to zero in scalar_unary_red_omp.cc - both g++ and clang++ #84

shivsundram opened this issue Aug 25, 2021 · 5 comments
Assignees
@manopapad

Comments

@shivsundram
Copy link

shivsundram commented Aug 25, 2021 •
edited

Summary:
There are 2 instances of what appears to be a comparison of a complex/bool/float (generic 'auto' variable) to zero in unary/scalar_unary_red_omp.c. g++ and clang++ both fail, saying there's no match for the != operator with the provided types.

unary/scalar_unary_red_omp.cc:130:77: error: no match for ‘operator!=’ (operand types are ‘const std::complex<float
>’ and ‘int’)

I've built legate.core (without cuda, see 'aside' at bottom of post) from source, have a pre-installed openblas, and get this error when building legate-numpy on both OSX and Ubuntu

Instances of zero comparison (unary/scalar_unary_red_omp.cc). Both trigger compiler errors
1:

  130 |         for (size_t idx = 0; idx < volume; ++idx) locals[tid] += inptr[idx] != 0;

2:

137         for (size_t idx = 0; idx < volume; ++idx) {
138           auto point = pitches.unflatten(idx, rect.lo);
139           locals[tid] += in[point] != 0;

Command
On ubuntu (OSX command is similar):

python3 install.py --with-core /home/shivneural/legate/legate.core/target --with-openblas /usr/lib/x86_64-linux-gnu/openblas-pthread/

Environment:
I'm encountering this error on both OSX and Ubuntu (and have tried a few different compilers):

  1. OSX 10.15.7 Catalina
    Compilers tried:
    a. clang++ version 12.0.0.
    b. clang++ Apple LLVM version 7.0.2 (clang-700.1.81)
    c. g++-11 (Homebrew GCC 11.1.0) 11.1.0 (fails due to different errors).

  2. Ubuntu 20.04.2 LTS (Focal Fossa)
    Compilers tried:
    a. g++ (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0.

Full error:

g++ -o unary/unary_red_omp.cc.o -c unary/unary_red_omp.cc   -fopenmp -I/home/shivneural/legate/legate.core/install/
thrust  -I. -I/usr/lib/x86_64-linux-gnu/openblas-pthread/include -std=c++14 -Wfatal-errors -I/home/shivneural/legat
e/legate.core/target/include -O2 -fno-strict-aliasing  -DLEGATE_USE_CUDA -I/include -fPIC -DLEGATE_USE_OPENMP
unary/scalar_unary_red_omp.cc: In instantiation of ‘void legate::numpy::ScalarUnaryRedImplBody<legate::numpy::Varia
ntKind::OMP, legate::numpy::UnaryRedCode::COUNT_NONZERO, CODE, DIM>::operator()(uint64_t&, legate::AccessorRO<typen
ame legate::LegateTypeOf<CODE>::type, DIM>, Legion::Rect<N>&, const legate::numpy::Pitches<(DIM - 1)>&, bool) const
 [with legate_core_type_code_t CODE = COMPLEX64_LT; int DIM = 1; uint64_t = long unsigned int; legate::AccessorRO<t
ypename legate::LegateTypeOf<CODE>::type, DIM> = Legion::FieldAccessor<LEGION_READ_PRIV, std::complex<float>, 1, lo
ng long int, Realm::AffineAccessor<std::complex<float>, 1, long long int>, false>; typename legate::LegateTypeOf<CO
DE>::type = std::complex<float>; Legion::Rect<N> = Realm::Rect<1, long long int>]’:
./unary/scalar_unary_red_template.inl:132:75:   required from ‘legate::numpy::UntypedScalar legate::numpy::ScalarUn
aryRedImpl<KIND, legate::numpy::UnaryRedCode::COUNT_NONZERO>::operator()(legate::numpy::ScalarUnaryRedArgs&) const 
[with legate_core_type_code_t CODE = COMPLEX64_LT; int DIM = 1; legate::numpy::VariantKind KIND = legate::numpy::Va
riantKind::OMP]’
/home/shivneural/legate/legate.core/target/include/utilities/dispatch.h:67:40:   required from ‘constexpr decltype(
auto) legate::inner_type_dispatch_fn<DIM>::operator()(legate::LegateTypeCode, Functor, Fnargs&& ...) [with Functor 
= legate::numpy::ScalarUnaryRedImpl<legate::numpy::VariantKind::OMP, legate::numpy::UnaryRedCode::COUNT_NONZERO>; F
nargs = {legate::numpy::ScalarUnaryRedArgs&}; int DIM = 1; legate::LegateTypeCode = legate_core_type_code_t]’
/home/shivneural/legate/legate.core/target/include/utilities/dispatch.h:141:41:   required from ‘constexpr decltype
(auto) legate::double_dispatch(int, legate::LegateTypeCode, Functor, Fnargs&& ...) [with Functor = legate::numpy::S
calarUnaryRedImpl<legate::numpy::VariantKind::OMP, legate::numpy::UnaryRedCode::COUNT_NONZERO>; Fnargs = {legate::n
umpy::ScalarUnaryRedArgs&}; legate::LegateTypeCode = legate_core_type_code_t]’
./unary/scalar_unary_red_template.inl:167:27:   required from ‘legate::numpy::UntypedScalar legate::numpy::scalar_u
nary_red_template(legate::TaskContext&) [with legate::numpy::VariantKind KIND = legate::numpy::VariantKind::OMP]’
unary/scalar_unary_red_omp.cc:151:61:   required from here
unary/scalar_unary_red_omp.cc:130:77: error: no match for ‘operator!=’ (operand types are ‘const std::complex<float
>’ and ‘int’)
  130 |         for (size_t idx = 0; idx < volume; ++idx) locals[tid] += inptr[idx] != 0;
      |                                                                  ~~~~~~~~~~~^~~~
compilation terminated due to -Wfatal-errors.
make: *** [/home/shivneural/legate/legate.core/target/share/legate/legate.mk:200: unary/scalar_unary_red_omp.cc.o] 
Error 1

Changing the 0 to a std::complex<float>(0.0f,0.0f) emits an error that the operand types are a bool and complex float.

Perhaps I'm configuring something incorrectly, in which case any guidance is appreciated.

(Aside: My Ubuntu machine is GCP instance w/ a T4 GPU, running cuda 10.1. When kicking of a legate-core with-cuda build it fails as it can't recognize the "_habs" half precision function when building legion
legate/legate.core/legion/runtime/mathtypes/half.h(364): error: identifier "__habs" is undefined. Looks like T4's Turing architecture isn't one of legate's supported platforms, but AFAIK Turing supports half precision)
Thanks
@manopapad manopapad self-assigned this Aug 25, 2021
@manopapad
Copy link
Contributor

Regarding the main issue, could you please try removing -Wfatal-errors from https://github.com/nv-legate/legate.core/blob/branch-21.10/src/legate.mk#L39 and rebuilding legate.numpy? This way we will get the full error message, including a list of the functions that the compiler tried to use at the site of !=. If the output gets messy you may want to run install.py with -j 1.

And just to confirm, are you on the latest commit from branch-21.10?

Regarding your aside, it looks like the check for availability of __habs is incorrect in Legion (this function was introduced in CUDA 10.2). I submitted a fix at https://gitlab.com/StanfordLegion/legion/-/merge_requests/404, and am waiting for it to pass CI.

@shivsundram
Copy link
Author

shivsundram commented Aug 26, 2021 •
edited

Yep, I'm on branch-21.10 w/ the latest commit

commit 49020b40950d7e5f3eb9531444a6da153865cce8
Author: Marcin Zalewski <marcin.zalewski@gmail.com>
Date:   Tue Aug 24 11:06:53 2021 -0700
    Always dump test output (#83)

Here's the full error on my OSX machine with Wfatal-errors disabled:

/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/clang++ -mlinker-version=253.9 -o unary/scalar_unary_red_omp.cc.o -c unary/scalar_unary_red_omp.cc   -fopenmp -I/Users/shivsundram/Desktop/coding/legate/legate.core/install/thrust  -I. -I/usr/local/Cellar/openblas/0.3.15_1/include -std=c++14 -Wfatal-errors -I/Users/shivsundram/Desktop/coding/legate/legate.core/install/include -O2 -fno-strict-aliasing  -fPIC -DLEGATE_USE_OPENMP
unary/scalar_unary_red_omp.cc:130:77: fatal error: invalid operands to binary expression ('const std::complex<float>' and 'int')
        for (size_t idx = 0; idx < volume; ++idx) locals[tid] += inptr[idx] != 0;
                                                                 ~~~~~~~~~~ ^  ~
./unary/scalar_unary_red_template.inl:132:5: note: in instantiation of member function 'legate::numpy::ScalarUnaryRedImplBody<legate::numpy::VariantKind::OMP, legate::numpy::UnaryRedCode::COUNT_NONZERO, COMPLEX64_LT, 1>::operator()' requested here
    ScalarUnaryRedImplBody<KIND, UnaryRedCode::COUNT_NONZERO, CODE, DIM>()(
    ^
/Users/shivsundram/Desktop/coding/legate/legate.core/install/include/utilities/dispatch.h:66:27: note: in instantiation of function template specialization 'legate::numpy::ScalarUnaryRedImpl<legate::numpy::VariantKind::OMP, legate::numpy::UnaryRedCode::COUNT_NONZERO>::operator()<COMPLEX64_LT, 1>' requested here
        return f.template operator()<LegateTypeCode::COMPLEX64_LT, DIM>(
                          ^
unary/scalar_unary_red_omp.cc:151:10: note: in instantiation of function template specialization 'legate::numpy::scalar_unary_red_template<legate::numpy::VariantKind::OMP>' requested here
  return scalar_unary_red_template<VariantKind::OMP>(context);
         ^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/system_error:419:1: note: candidate function not viable: no known conversion from 'const std::complex<float>' to 'const std::error_code' for 1st argument
operator!=(const error_code& __x, const error_code& __y) _NOEXCEPT
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/system_error:424:1: note: candidate function not viable: no known conversion from 'const std::complex<float>' to 'const std::error_code' for 1st argument
operator!=(const error_code& __x, const error_condition& __y) _NOEXCEPT
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/system_error:429:1: note: candidate function not viable: no known conversion from 'const std::complex<float>' to 'const std::error_condition' for 1st argument
operator!=(const error_condition& __x, const error_code& __y) _NOEXCEPT
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/system_error:434:1: note: candidate function not viable: no known conversion from 'const std::complex<float>' to 'const std::error_condition' for 1st argument
operator!=(const error_condition& __x, const error_condition& __y) _NOEXCEPT
^
/Users/shivsundram/Desktop/coding/legate/legate.core/install/include/mathtypes/half.h:602:13: note: candidate function not viable: no known conversion from 'const std::complex<float>' to 'const __half' for 1st argument
inline bool operator!=(const __half &one, const __half &two)
            ^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/complex:776:1: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('float' vs. 'int')
operator!=(const complex<_Tp>& __x, const _Tp& __y)
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/utility:584:1: note: candidate template ignored: could not match 'pair' against 'complex'
operator!=(const pair<_T1,_T2>& __x, const pair<_T1,_T2>& __y)
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/iterator:819:1: note: candidate template ignored: could not match 'reverse_iterator' against 'complex'
operator!=(const reverse_iterator<_Iter1>& __x, const reverse_iterator<_Iter2>& __y)
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/iterator:1041:1: note: candidate template ignored: could not match 'istream_iterator' against 'complex'
operator!=(const istream_iterator<_Tp, _CharT, _Traits, _Distance>& __x,
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/iterator:1152:6: note: candidate template ignored: could not match 'istreambuf_iterator' against 'complex'
bool operator!=(const istreambuf_iterator<_CharT,_Traits>& __a,
     ^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/iterator:1275:1: note: candidate template ignored: could not match 'move_iterator' against 'complex'
operator!=(const move_iterator<_Iter1>& __x, const move_iterator<_Iter2>& __y)
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/iterator:1651:1: note: candidate template ignored: could not match '__wrap_iter' against 'complex'
operator!=(const __wrap_iter<_Iter1>& __x, const __wrap_iter<_Iter2>& __y) _NOEXCEPT
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/iterator:1683:1: note: candidate template ignored: could not match '__wrap_iter' against 'complex'
operator!=(const __wrap_iter<_Iter1>& __x, const __wrap_iter<_Iter1>& __y) _NOEXCEPT
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/tuple:1185:1: note: candidate template ignored: could not match 'tuple' against 'complex'
operator!=(const tuple<_Tp...>& __x, const tuple<_Up...>& __y)
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/memory:979:6: note: candidate template ignored: could not match 'allocator' against 'complex'
bool operator!=(const allocator<_Tp>&, const allocator<_Up>&) _NOEXCEPT {return false;}
     ^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/memory:1917:1: note: candidate template ignored: could not match 'unique_ptr' against 'complex'
operator!=(const unique_ptr<_T1, _D1>& __x, const unique_ptr<_T2, _D2>& __y) {return !(__x == __y);}
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/memory:1964:1: note: candidate template ignored: could not match 'unique_ptr' against 'complex'
operator!=(const unique_ptr<_T1, _D1>& __x, nullptr_t) _NOEXCEPT
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/memory:1972:1: note: candidate template ignored: could not match 'unique_ptr<type-parameter-0-0, type-parameter-0-1>' against 'int'
operator!=(nullptr_t, const unique_ptr<_T1, _D1>& __x) _NOEXCEPT
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/memory:3383:1: note: candidate template ignored: could not match 'shared_ptr' against 'complex'
operator!=(const shared_ptr<_Tp>& __x, const shared_ptr<_Up>& __y) _NOEXCEPT
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/memory:3445:1: note: candidate template ignored: could not match 'shared_ptr' against 'complex'
operator!=(const shared_ptr<_Tp>& __x, nullptr_t) _NOEXCEPT
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/memory:3453:1: note: candidate template ignored: could not match 'shared_ptr<type-parameter-0-0>' against 'int'
operator!=(nullptr_t, const shared_ptr<_Tp>& __x) _NOEXCEPT
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/functional:2603:1: note: candidate template ignored: could not match 'function' against 'complex'
operator!=(const function<_Rp(_ArgTypes...)>& __f, nullptr_t) _NOEXCEPT {return (bool)__f;}
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/functional:2608:1: note: candidate template ignored: could not match 'function<type-parameter-0-0 (type-parameter-0-1...)>' against 'int'
operator!=(nullptr_t, const function<_Rp(_ArgTypes...)>& __f) _NOEXCEPT {return (bool)__f;}
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/map:1614:1: note: candidate template ignored: could not match 'map' against 'complex'
operator!=(const map<_Key, _Tp, _Compare, _Allocator>& __x,
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/map:2199:1: note: candidate template ignored: could not match 'multimap' against 'complex'
operator!=(const multimap<_Key, _Tp, _Compare, _Allocator>& __x,
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/set:918:1: note: candidate template ignored: could not match 'set' against 'complex'
operator!=(const set<_Key, _Compare, _Allocator>& __x,
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/set:1445:1: note: candidate template ignored: could not match 'multiset' against 'complex'
operator!=(const multiset<_Key, _Compare, _Allocator>& __x,
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/list:2436:1: note: candidate template ignored: could not match 'list' against 'complex'
operator!=(const list<_Tp, _Alloc>& __x, const list<_Tp, _Alloc>& __y)
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/deque:2978:1: note: candidate template ignored: could not match 'deque' against 'complex'
operator!=(const deque<_Tp, _Allocator>& __x, const deque<_Tp, _Allocator>& __y)
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/vector:3346:1: note: candidate template ignored: could not match 'vector' against 'complex'
operator!=(const vector<_Tp, _Allocator>& __x, const vector<_Tp, _Allocator>& __y)
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/string_view:682:6: note: candidate template ignored: could not match 'basic_string_view' against 'complex'
bool operator!=(basic_string_view<_CharT, _Traits> __lhs, basic_string_view<_CharT, _Traits> __rhs) _NOEXCEPT
     ^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/string_view:691:6: note: candidate template ignored: could not match 'basic_string_view' against 'complex'
bool operator!=(basic_string_view<_CharT, _Traits> __lhs,
     ^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/string_view:701:6: note: candidate template ignored: could not match 'basic_string_view<type-parameter-0-0, type-parameter-0-1>' against 'int'
bool operator!=(typename common_type<basic_string_view<_CharT, _Traits> >::type __lhs,
     ^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/string:575:6: note: candidate template ignored: could not match 'fpos' against 'complex'
bool operator!=(const fpos<_StateT>& __x, const fpos<_StateT>& __y)
     ^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/string:4090:1: note: candidate template ignored: could not match 'basic_string' against 'complex'
operator!=(const basic_string<_CharT,_Traits,_Allocator>& __lhs,
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/string:4099:1: note: candidate template ignored: could not match 'const _CharT *' against 'std::complex<float>'
operator!=(const _CharT* __lhs,
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/string:4108:1: note: candidate template ignored: could not match 'basic_string' against 'complex'
operator!=(const basic_string<_CharT, _Traits, _Allocator>& __lhs,
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/complex:768:1: note: candidate template ignored: could not match 'complex<type-parameter-0-0>' against 'int'
operator!=(const complex<_Tp>& __x, const complex<_Tp>& __y)
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/complex:784:1: note: candidate template ignored: could not match 'complex<type-parameter-0-0>' against 'int'
operator!=(const _Tp& __x, const complex<_Tp>& __y)
^
/Users/shivsundram/Desktop/coding/compiler/llvm12/clang+llvm-12.0.0-x86_64-apple-darwin/bin/../include/c++/v1/array:381:1: note: candidate template ignored: could not match 'array' against 'complex'
operator!=(const array<_Tp, _Size>& __x, const array<_Tp, _Size>& __y)
^
1 error generated.
make: *** [unary/scalar_unary_red_omp.cc.o] Error 1
Traceback (most recent call last):
  File "/Users/shivsundram/Desktop/coding/legate/legate.numpy/install.py", line 498, in <module>
    driver()
  File "/Users/shivsundram/Desktop/coding/legate/legate.numpy/install.py", line 494, in driver
    install_legate_numpy(unknown=unknown, **vars(args))
  File "/Users/shivsundram/Desktop/coding/legate/legate.numpy/install.py", line 364, in install_legate_numpy
    build_legate_numpy(
  File "/Users/shivsundram/Desktop/coding/legate/legate.numpy/install.py", line 238, in build_legate_numpy
    execute_command(
  File "/Users/shivsundram/Desktop/coding/legate/legate.numpy/install.py", line 84, in execute_command
    subprocess.check_call(args, cwd=cwd, shell=shell)
  File "/usr/local/Cellar/python@3.9/3.9.5/Frameworks/Python.framework/Versions/3.9/lib/python3.9/subprocess.py", line 373, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['make', 'LEGATE_DIR=/Users/shivsundram/Desktop/coding/legate/legate.core/install', 'OPEN_BLAS_DIR=/usr/local/Cellar/openblas/0.3.15_1', 'DEBUG=0', 'DEBUG_RELEASE=0', 'CHECK_BOUNDS=0', 'USE_CUDA=0', 'USE_OPENMP=1', 'PREFIX=/Users/shivsundram/Desktop/coding/legate/legate.core/install', 'OPENBLAS_FLAGS = -L/usr/local/Cellar/openblas/0.3.15_1/lib -lopenblas -Wl,-rpath,/usr/local/Cellar/openblas/0.3.15_1/lib', '-j', '1', 'install']' returned non-zero exit status 2.

And thank you for submitting the __habs fix 👍

manopapad added a commit to manopapad/cunumeric that referenced this issue Aug 26, 2021
@manopapad
Attempt to address nv-legate#84
a96310d
@manopapad
Copy link
Contributor

I think I have a fix on #86, waiting for it to pass CI. Please try it at your convenience and let me know if it fixes the issue for you.

@shivsundram
Copy link
Author

Yes that fixed it, and I'm able to run cg.py example on my Ubuntu machine. Thank you! 💯

manopapad added a commit that referenced this issue Aug 26, 2021
@manopapad
Merge pull request #86 from manopapad/bug84
2fb2606 
Attempt to address #84
@manopapad
Copy link
Contributor

Thanks for verifying, #86 has been merged, and the __habs fix will eventually make its way to the legate_stable Legion branch that Legate tracks.

manopapad pushed a commit to manopapad/cunumeric that referenced this issue Feb 14, 2024
@magnatelee
Catch up changes in the create_store_from_buffer API (nv-legate#84)
b938761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manopapad manopapad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manopapad @shivsundram