-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] "Show PDF" button #72
Conversation
81aea5a
to
65ae7a2
Compare
At present, I think the filename conversion is okay. Doing better depends on finding a good way to decide which files get compiled into PDFs and what those PDFs should be called, which hasn't happened yet. |
@dvdvgt can you fix the failing lint? This will be ready to merge after that. |
Should be good now. Feel free to squash all commits into one. |
Oops, that latest failure might have been my fault; I needed an extra feature in a dependency, and I force pushed while preparing a PR to upstream the changes. My changes were upstreamed but not yet released, so it's okay to keep the |
Thank you! |
This PR is in response to #69.
Discussion
I am not really happy how the file extension/type is currently manually changed from
.typ
to.pdf
. I'll happily implement something more robust if somebody has a recommendation.