Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fd to /dev/gdrdrv should not be sharable with other processes #62

Closed
pakmarkthub opened this issue Jun 12, 2019 · 1 comment
Closed

fd to /dev/gdrdrv should not be sharable with other processes #62

pakmarkthub opened this issue Jun 12, 2019 · 1 comment
Assignees
@pakmarkthub
Milestone
2.0

Comments

@pakmarkthub
Copy link
Collaborator

Since struct file in gdrdrv keeps the internal data for the process that opened the file, being able to share the fd can lead to undesired behaviors. Create a unit test to make sure that fd is not sharable:

  • via fork
  • via dup
  • via unix socket
@pakmarkthub pakmarkthub self-assigned this Jun 12, 2019
@pakmarkthub pakmarkthub mentioned this issue Jun 12, 2019
Merged
@drossetti drossetti added this to the 2.0 milestone Jun 20, 2019
@pakmarkthub
Copy link
Collaborator Author

Merged the PR.

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pakmarkthub pakmarkthub

Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@drossetti @pakmarkthub