Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Nvidia Device plugin with more health checking features #12

Open
jiayingz opened this issue Dec 8, 2017 · 5 comments
Open

Enhance Nvidia Device plugin with more health checking features #12

jiayingz opened this issue Dec 8, 2017 · 5 comments
Labels
feature issue/PR that proposes a new feature or functionality lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@jiayingz
Copy link

jiayingz commented Dec 8, 2017

Quoting what @RenaudWasTaken mentioned in another thread:
"The Nvidia Device plugin has a lot of such features coming up a few of these are:

memory scrubbing
healthCheck and reset in case of bad state
GPU Allocated memory checks
"Zombie processes" checks
...
"

Creating this issue to track the progress on these improvements.

@RenaudWasTaken could you also provide more details on some of these features, like what GPU Allocated memory checks and "Zombie processes" checks do?

@jiayingz
Copy link
Author

jiayingz commented Dec 8, 2017

cc @jiayingz @vishh @mindprince

@flx42
Copy link
Member

flx42 commented Dec 8, 2017

what GPU Allocated memory checks and "Zombie processes" checks do?

Those are related, and it's related to reset too. If it's not possible to reset your card, you at least need to detect when things are broken.

When things go awfully wrong, you can have the following:

  • There is no process using the GPU, but nvidia-smi shows a non-trivial amount of memory being used. e.g. something like 352MiB / 12181MiB
  • There is a process already using the GPU you are supposed to give to a new container (excluding voluntary sharing). This can happen when there is a GPU fault and the process that had an open CUDA context can't teardown properly.

These kinds of checks are useful safety checks in addition to event-based healthchecks like XIDs and ECCs. Some of these errors could go unnoticed otherwise.

@flx42 flx42 closed this as completed Dec 8, 2017
@flx42 flx42 reopened this Dec 8, 2017
@ScorpioCPH
Copy link
Contributor

@flx42 Thanks for your detailed explanation, it's very useful for us!

@wsxiaozhang
Copy link

@flx42 @jiayingz any plan to enhance current device health check?

Meoop added a commit to Meoop/k8s-device-plugin that referenced this issue Dec 8, 2020
@ArangoGutierrez ArangoGutierrez added feature issue/PR that proposes a new feature or functionality and removed feature-request labels Feb 22, 2024
Copy link

This issue is stale because it has been open 90 days with no activity. This issue will be closed in 30 days unless new comments are made or the stale label is removed.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature issue/PR that proposes a new feature or functionality lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

7 participants