Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression_test.py is misnamed #59

Closed
orion opened this issue Dec 13, 2017 · 1 comment
Closed

regression_test.py is misnamed #59

orion opened this issue Dec 13, 2017 · 1 comment

Comments

@orion
Copy link
Contributor

orion commented Dec 13, 2017

I know this has been on the TBD list for awhile, but perhaps now is a good time to actually do it as people are starting to take a look at the project. Probably a better presentation is a Makefile with one or more support scripts written in python.

@edmc-ss
Copy link
Collaborator

edmc-ss commented Dec 24, 2017

There is now a Makefile in the repo that is the equivalent of the misleadingly named regression_test.py. It has a number of build targets, but the default (all) is equivalent to what regression_test.py would do both in a Linux (e.g. CentOS) environment and in a cross development environment (e.g. MacOS where there is no ability to build the C submodules).

Note that the Makefile convention has also been added to the two Golang packages in the cstruct and sortedmap repos.

@edmc-ss edmc-ss closed this as completed Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants