Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input from cinematics gets into the game #337

Closed
apanteleev opened this issue Oct 7, 2023 · 3 comments
Closed

Input from cinematics gets into the game #337

apanteleev opened this issue Oct 7, 2023 · 3 comments

Comments

@apanteleev
Copy link
Collaborator

When you skip a cinematic, the key you used to skip it is processed as the first input in the game. For example, skip it with space, and the character will jump when map loads.

I noticed this new behavior after this PR #328 (Sync with Q2PRO: Game changes)
Does not reproduce before it.

@res2k can you take a look please?

@res2k
Copy link
Contributor

res2k commented Oct 7, 2023

I narrowed down the culprit to f6d2202.
It looks like actions were always forwarded/processed, just that they didn't have a (visible) effect.
I addressed by explicitly not producing a command when skipping a cinematic: #338

@res2k
Copy link
Contributor

res2k commented Oct 7, 2023

@apanteleev, there are two flavors of a fix:

  • 6cf8c04 - What I came up with, before being made aware of ...
  • 8afce9e, the fix for that in upstream.

Both do essentially the job, but it appears to me as if the "upstream" change is somewhat sensitive ("lightly tapping" skips the cinematic, but holding a key beyond that seems to trigger the action after all)... Maybe, if you have time, give both a try and let me know which behavior you prefer.

@apanteleev
Copy link
Collaborator Author

Thanks! I think the upstream solution is fine. I just cherry-picked it into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants