Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not save JSON summaries by default #91

Closed
wjxiz1992 opened this issue Aug 11, 2022 · 1 comment · Fixed by #78
Closed

Do not save JSON summaries by default #91

wjxiz1992 opened this issue Aug 11, 2022 · 1 comment · Fixed by #78
Assignees

Comments

@wjxiz1992
Copy link
Collaborator

If --json_summary_folder arg is not specified, the JSON summary files will be saved to the default folder "json-summary" by default.
When we run the test for the second time, we detect if the json_summary folder has any files inside, if so, the code will raise an exception to protect those existed summaries.
Some users complain it's really annoying and they don't need those summary files.
Also when running Throughput Test, if this json_summary argument is not specified differently, the run will fail due to duplicated summary folder name.

@wjxiz1992 wjxiz1992 self-assigned this Aug 11, 2022
@GaryShen2008
Copy link
Collaborator

Since our CI jobs specify --json_summary_folder always, we can simply modify the script that don't save JSON summary when not setting --json_summary_folder. It won't impact the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants