Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty sample project taking almost 3 GB of memory in DX12 #63

Closed
Alekssasho opened this issue Apr 20, 2018 · 3 comments
Closed

Empty sample project taking almost 3 GB of memory in DX12 #63

Alekssasho opened this issue Apr 20, 2018 · 3 comments
Assignees
Milestone

Comments

@Alekssasho
Copy link

When creating new Device you create a QueryHeap for the GPUTimers with very large count of 128 * 1024 * 1024.
This is happening on this line https://github.com/NVIDIAGameWorks/Falcor/blob/master/Framework/Source/API/Device.cpp#L84.
This is allocating enormous amount of memory.

This seems unnecessary large and should be either lowered or made a constant that can be user changed for example in Device::Desc

@nbentyNV
Copy link
Contributor

nbentyNV commented Apr 20, 2018

I assume you're running Vulkan. The DX12 backend only consumes 130MB.
Just read the title. Weird, I'm seeing 130MB. What GPU are you using?

We will fix it for the next release - add options to control the number of GPU queries and the sizes of the descriptor heaps.

@nbentyNV nbentyNV self-assigned this Apr 20, 2018
@nbentyNV nbentyNV added this to the 3.0.2 milestone Apr 20, 2018
@Alekssasho
Copy link
Author

Actually it is both Dx12 and Vulkan. The number you are passing is the count of slots, but every query slot is taking more than 1 byte, so is both Vulkan and Dx12 this is a lot more than 128 MB.

@nbentyNV
Copy link
Contributor

I changed the number to 50000. I'm replacing this issue with #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants