Compile error when Windows language is Chinese

[csyonghe]

I am using Windows 10 with my OS code page set to 936. When compiling Falcor I got the following error message from msvc:

d:\git_repo\falcornv\falcor\framework\externals\ffmpeg\include\libavutil\rational.h : warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss (compiling source file Utils\Video\VideoEncoder.cpp)

Because treat warnings as errors is turned on, I cannot get Falcor to compile due to this error message. Save the file as UTF8 does not solve the issue, and I cannot locate the offending characater in rational.h.

The workaround is to suppress warning 4819 in project settings. (using pragma in rational.h does not work)

[nbentyNV]

That error is from an external dependency. We will investigate.
@kyaoNV , this one is yours

[kyaoNV]

This is an issue from FFMPEG, we can't do anything about it.

[csyonghe]

I think you can disable that warning in visual studio project file.