Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screenshots in README.md #106

Closed
shadmansaleh opened this issue Feb 20, 2021 · 8 comments
Closed

Update screenshots in README.md #106

shadmansaleh opened this issue Feb 20, 2021 · 8 comments
Labels
enhancement General improvements or improvement request

Comments

@shadmansaleh
Copy link
Member

Since component separators were added we should update the screenshots in README.md as that's the landing page . THEMES.md can be updated too though that will be good amount of work . @hoob3rt didn't you say you had a script for screenshots?

May be update the screenshot when diagnostics is added :) . What do you think?

@hoob3rt
Copy link
Contributor

hoob3rt commented Feb 20, 2021

I've got a script ready to create screenshots of the same size in bspwm. WIll do after I merge #95

@hoob3rt hoob3rt added the enhancement General improvements or improvement request label Feb 21, 2021
@hoob3rt
Copy link
Contributor

hoob3rt commented Feb 22, 2021

Should be done with 41e670a and 3ae9a2a

@hoob3rt hoob3rt closed this as completed Feb 22, 2021
@shadmansaleh
Copy link
Member Author

I'm not sure what you did in THEMES.md but the screenshots donn't have section separators ... Did you plan to add them ?

@hoob3rt
Copy link
Contributor

hoob3rt commented Feb 22, 2021

I updated all screenshots in THEMES.md to be the same size and same config to look cleaner and changed screenshots in README.md to reflect different possible configurations. I don't see an issue here

@shadmansaleh
Copy link
Member Author

No issue . I thought your script was gona take new screenshot . Seems thats not the case 😅.

@hoob3rt
Copy link
Contributor

hoob3rt commented Feb 22, 2021

No issue . I thought your script was gona take new screenshot . Seems thats not the case 😅.

I don't get it. Literally every single screenshot is new. Take a look at how bad it looked before my change.

@shadmansaleh
Copy link
Member Author

I don't get it. Literally every single screenshot is new. Take a look at how bad it looked before my change.

So you took screenshot while section separators disabled?

@hoob3rt
Copy link
Contributor

hoob3rt commented Feb 22, 2021

Yes, I don't know how that's hard to understand. The point of themes.md is to reflect different theme options not configuration options. There are screenshots of different configurations in readme.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements or improvement request
Projects
None yet
Development

No branches or pull requests

2 participants