Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for lightline colorschemes #34

Closed
hoob3rt opened this issue Jan 6, 2021 · 9 comments
Closed

add support for lightline colorschemes #34

hoob3rt opened this issue Jan 6, 2021 · 9 comments
Labels
discuss enhancement General improvements or improvement request new feature New feature or feature request

Comments

@hoob3rt
Copy link
Contributor

hoob3rt commented Jan 6, 2021

As mentioned here, having the ability to use lightline's colorschemes would be a nice feature to have.

@hoob3rt hoob3rt added enhancement General improvements or improvement request help wanted Extra attention is needed new feature New feature or feature request discuss labels Jan 6, 2021
@shadmansaleh
Copy link
Member

shadmansaleh commented Jan 10, 2021

I think they will have to be ported . Those colorscemes are written in vimscript you are oviously not hoping to interprete them...

@hoob3rt
Copy link
Contributor Author

hoob3rt commented Jan 10, 2021

t you are oviously not hoping to interprete them...

Yeah obviously not. The themes in lightline's main repo should and will be ported. This issue's aim is to discuss the possibility of using lightline's highlight groups in lualine.

The gruvbox theme I am using comes with both airline and lightline themes supplied, it would be great to have support for them.

But keep in mind this thread is for discussion only, I should remove the help wanted label.

Using lightline colorschemes will be redundant when #26 is implemented correctly.

@hoob3rt hoob3rt removed the help wanted Extra attention is needed label Jan 10, 2021
@coxackie
Copy link

Do you mean that after #26 in implemented, there will be no colour schemes any more? Or will they be optional? My opinion is that, if #26 is actually successful, colour schemes should be dropped. This will relieve future maintenance significantly.

@shadmansaleh
Copy link
Member

My opinion is that, if #26 is actually successful, colour schemes should be dropped.

I donn't think it should be droped . I shouldn't be forced to use same colorscheme on both editor and statusline . I should be able to chose separately.

Also I don't think themes require much maintanace .

@coxackie
Copy link

perfectly fine also, just make sure there is an option if we want to opt in matching the colorscheme on editor and statusline. I personally like the consistency that it would bring, but understandably there will be others that like more variety.

@hoob3rt
Copy link
Contributor Author

hoob3rt commented Jan 12, 2021

perfectly fine also, just make sure there is an option if we want to opt in matching the colorscheme on editor and statusline. I personally like the consistency that it would bring, but understandably there will be others that like more variety.

Yes there will be. I think providing some popular themes out of the box is nice but you will also be able to set theme=auto to keep things easy and consistent

@shadmansaleh
Copy link
Member

shadmansaleh commented Jan 13, 2021

lightline to lualine theme converter

link

Open the file in vim with lightline installed. And run :luafile %
execute :lua light2lualine_theme_converter('theme_name')
. And you will have the theme . You can change the install_dir to set were you want the file to be . By default it will be in your current dir.

So basicaly any theme available for lightline is now also available for lualine . As we find someone to do the screenshots for THEMES.md

@hoob3rt
Copy link
Contributor Author

hoob3rt commented Feb 18, 2021

@shadmansaleh the link and usage to your theme converter should be in the readme imo

@shadmansaleh
Copy link
Member

the link and usage to your theme converter should be in the readme imo

Ha ha . I had written it as a throwaway script when I was conberting themes. As it was doing a pretty good job I shared it as a gist so it might be helpful if someone else is converting themes . When I was writting it I had no intention of sharing it . So it's horrible to look at . If you want to put it in README.md you can . The gist has uses instructions . So putting the link should be enough . Maybe in contributing.md insted of README.md.

@hoob3rt hoob3rt closed this as completed Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss enhancement General improvements or improvement request new feature New feature or feature request
Projects
None yet
Development

No branches or pull requests

3 participants