Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom mappings not being used #22

Closed
cseickel opened this issue Jan 9, 2022 · 0 comments
Closed

Custom mappings not being used #22

cseickel opened this issue Jan 9, 2022 · 0 comments
Assignees
Labels
bug Something isn't working working-on-it

Comments

@cseickel
Copy link
Contributor

cseickel commented Jan 9, 2022

User supplied mappings are not overriding the default ones.

EDIT: To be more precise, mappings with special characters, that may have multiple forms or are case insensitive, could create conflicts with default mappings. For example, a mapping of <BS> would not overwite the default mapping of <bs>, so both would be applied in an unknown order with unpredictable results.

The fix is to normalize those types of mapping to make sure that user supplied versions properly overwrite the default ones.

@cseickel cseickel added bug Something isn't working working-on-it labels Jan 9, 2022
@cseickel cseickel self-assigned this Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working working-on-it
Projects
None yet
Development

No branches or pull requests

1 participant