Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cursor in float #38

Closed
mbriggs opened this issue Jan 10, 2022 · 8 comments
Closed

cursor in float #38

mbriggs opened this issue Jan 10, 2022 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@mbriggs
Copy link

mbriggs commented Jan 10, 2022

Love the plugin :)

When I open the float panel in a buffer not pointing to a file, the popup will show with an invisible cursor

image

I can move around, open and close folders, but cursor is hidden.

You can see here, when I open on a file that exists on the fs, the cursor exists (over the icon of snippets.lua)

image

However, in the above case, cursorline does not seem to be set (you can see cursorline highlight in the window the float popped over.

@danilshvalov
Copy link
Contributor

Which terminal do you use?

@cseickel
Copy link
Contributor

Can you check (and possibly set) the value for NeoTreeCursorLine?

:hi NeoTreeCursorLine

@mbriggs
Copy link
Author

mbriggs commented Jan 10, 2022

Which terminal do you use?

Alacritty compiled from source in the last few months. But cursorline works fine

@mbriggs
Copy link
Author

mbriggs commented Jan 10, 2022

Can you check (and possibly set) the value for NeoTreeCursorLine?

:hi NeoTreeCursorLine

image

that appears to be the problem! I was under the impression that cursorline is copied by default

image

but that does not appear to be happening

@cseickel
Copy link
Contributor

Curious, that should have linked to CursorLine. I run some tests and see if I can recreate the issue.

@cseickel cseickel added the bug Something isn't working label Jan 10, 2022
@cseickel cseickel self-assigned this Jan 10, 2022
@mbriggs
Copy link
Author

mbriggs commented Jan 10, 2022

I tried adding the highlight explicitly, and still see the same behaviour

image
image

my relevent configs are here https://github.com/mbriggs/nvim/blob/main/lua/mb/explorer.lua but I am largely just copy/pasta from the README

@cseickel
Copy link
Contributor

I'm sorry, there is absolutely a problem with CursorLine in the floating window, I'm not sure how I never noticed this. I'll fix that soon.

@mbriggs
Copy link
Author

mbriggs commented Jan 12, 2022

working, thank you @cseickel :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants