refactor(codebase)!: make the neorg object local to a core module
#1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're a beast for this, thank you. I did an all round check of everything (took me a while lol) but there's probably some stuff I might've missed. I hope the community will tell us soon enough whether anything's broken or not haha After all of your PRs are done I think it's prime time to implement test suites :D |
vhyrro
changed the title
neorg object local to a core moduleneorg object local to a core module
This was referenced Aug 2, 2023
pysan3
pushed a commit
to pysan3/neorg-templates
that referenced
this pull request
Aug 4, 2023
Reference: nvim-neorg/neorg#1001 Closes: #9
pysan3
pushed a commit
to pysan3/neorg-templates
that referenced
this pull request
Aug 4, 2023
Reference: nvim-neorg/neorg#1001 Closes: #9
pysan3
added a commit
to pysan3/neorg-templates
that referenced
this pull request
Aug 4, 2023
Reference: nvim-neorg/neorg#1001 Closes: #9
tamton-aquib
added a commit
to tamton-aquib/neorg-jupyter
that referenced
this pull request
Dec 23, 2023
benlubas
pushed a commit
to benlubas/neorg
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR aimed to address the refactor discussed at #999. The first step in refactoring the code base is moving the
neorgobject to theneorg.coremodule, which other modules canrequirefrom. This one is a big PR, since it touches most if not all files in the project. However, it is necessary to remove the sequencing necessity for loading theneorgobject when it is defined as a global variable.Please take your time to review that everything in this first change set is correct. After this, I will address the events system as I had already done on January to separate it from the module loader. I have left this task outside of this PR temporarily to strictly focus on the relocation of the
neorgobject.