feat: add blank lines between tangled blocks #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the force push; I copied the wrong issue number. |
jonathf
added a commit
to jonathf/neorg
that referenced
this pull request
Jul 6, 2023
An extention to the idea discussed in nvim-neorg#958. Add heading text as delimiter if: 1. There is in-fact a current heading. Headings are optional. 2. Current heading hasn't been used as a delimiter before. 3. `commentstring` is available for the filetype in question. That last one requires making a temporary scratch buffer to trigger ftplugin, which retrieves `commentstring` for all supported filetypes in vim.
jonathf
added a commit
to jonathf/neorg
that referenced
this pull request
Jul 6, 2023
An extention to the idea discussed in nvim-neorg#958. Add heading text as delimiter as a comment if: 1. There is in-fact a current heading. Headings are optional. 2. Current heading hasn't been used as a delimiter before. 3. `commentstring` is available for the filetype in question. Otherwise just use a newline. That last one (3) requires making a temporary scratch buffer to trigger ftplugin, which retrieves `commentstring` for all supported filetypes in vim.
|
Happy to close in favor of #981, if that gets merged. Will leave it open in case we prefer the lower-complexity solution. |
jonathf
added a commit
to jonathf/neorg
that referenced
this pull request
Jul 7, 2023
An extention to the idea discussed in nvim-neorg#958. Add heading text as delimiter as a comment if: 1. There is in-fact a current heading. Headings are optional. 2. Current heading hasn't been used as a delimiter before. 3. `commentstring` is available for the filetype in question. Otherwise just use a newline. That last one (3) requires making a temporary scratch buffer to trigger ftplugin, which retrieves `commentstring` for all supported filetypes in vim.
|
As we discussed in the other thread, at some point we would also like this to be configurable. In the meantime though this is perfectly fine, thank you! 💜 |
jonathf
added a commit
to jonathf/neorg
that referenced
this pull request
Aug 2, 2023
An extention to the idea discussed in nvim-neorg#958. Add heading text as delimiter as a comment if: 1. There is in-fact a current heading. Headings are optional. 2. Current heading hasn't been used as a delimiter before. 3. `commentstring` is available for the filetype in question. Otherwise just use a newline. That last one (3) requires making a temporary scratch buffer to trigger ftplugin, which retrieves `commentstring` for all supported filetypes in vim.
benlubas
pushed a commit
to benlubas/neorg
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #955.