Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: On close of TOC, only delete buffer if it exists #978

Merged
merged 2 commits into from
Jul 7, 2023
Merged

fix: On close of TOC, only delete buffer if it exists #978

merged 2 commits into from
Jul 7, 2023

Conversation

madskjeldgaard
Copy link
Contributor

This fixes #977

@vhyrro
Copy link
Member

vhyrro commented Jul 7, 2023

Thanks for the PR!
Similarly to a PR made by another new contributor, could you please run stylua on the code to keep things consistent? There's a Makefile providing a make format for this :D

Be sure to have stylua installed with lua5.2 features: cargo install stylua --features lua52.
I believe your code is using tabs instead of the spaces enforced by the formatter.

@madskjeldgaard
Copy link
Contributor Author

Sure – done!

@vhyrro
Copy link
Member

vhyrro commented Jul 7, 2023

💜

@vhyrro vhyrro merged commit 32bae17 into nvim-neorg:main Jul 7, 2023
1 of 2 checks passed
@github-actions github-actions bot mentioned this pull request Jul 7, 2023
Merged
benlubas pushed a commit to benlubas/neorg that referenced this pull request Jan 11, 2024
@madskjeldgaard @benlubas
fix: On close of TOC, only delete buffer if it exists (nvim-neorg#978)
e3a45ff 
fixes nvim-neorg#977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NTBBloodbath NTBBloodbath NTBBloodbath approved these changes

@vhyrro vhyrro Awaiting requested review from vhyrro vhyrro is a code owner

@mrossinek mrossinek Awaiting requested review from mrossinek mrossinek is a code owner

@danymat danymat Awaiting requested review from danymat danymat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toggling Neorg toc results in "invalid buffer id" error
3 participants
@madskjeldgaard @vhyrro @NTBBloodbath