fix: replace get_filetype with vim.filetype.match
#982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`utils.get_filetype` doesn't seem to work in autocmd like `BufWritePre` and `BufWritePost`, which is a real problem if you like to set up auto-tangle. Fortunatly, neovim 0.8 introduce `vim.filetype.match` that does the same natively without issues. Since the complexity of `get_filetype` has become trivial, I've deprecated the function.
|
Awesome, thank you! Could you please run stylua on the code to keep things consistent? There's a makefile providing a Be sure to have stylua installed with lua5.2 features: |
|
Of course. Looks like the linter is complaining now. I ran luacheck locally, I don't have the same issue. In fact, I don't think the error it is seeing there is really there. Might this be a caching issue perhaps? |
|
I'll take a look at the linter later on, it could just be confused haha. Thank you again! |
vhyrro
changed the title
get_filetype with vim.filetype.match
benlubas
pushed a commit
to benlubas/neorg
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils.get_filetypedoesn't seem to work in autocmd likeBufWritePreandBufWritePost, which is a real problem if you like to set up auto-tangle.Fortunatly, neovim 0.8 introduce
vim.filetype.matchthat does the same natively without issues.Since the complexity of
get_filetypehas become trivial, I've deprecated the function.