Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Plugin dependencies added to rocks.toml when updated #140

Closed
NTBBloodbath opened this issue Feb 11, 2024 · 2 comments · Fixed by #143
Closed

[Bug] Plugin dependencies added to rocks.toml when updated #140

NTBBloodbath opened this issue Feb 11, 2024 · 2 comments · Fixed by #143
Labels
bug Something isn't working

Comments

@NTBBloodbath
Copy link
Member

As the title says, whenever a plugin dependency gets updated through :Rocks update, it is added as a new entry to the rocks.toml entry, causing some unexpected junk entries.

This one is a bit more hard to reproduce so I cannot really give reliable reproduction steps here, hope it's not a blocker!

@NTBBloodbath NTBBloodbath added the bug Something isn't working label Feb 11, 2024
@NTBBloodbath NTBBloodbath changed the title [Bug] Plugins dependencies added to rocks.toml when updated [Bug] Plugin dependencies added to rocks.toml when updated Feb 11, 2024
@mrcjkb
Copy link
Member

mrcjkb commented Feb 11, 2024

@NTBBloodbath can you add some of the junk entries that were added? 🙏

@NTBBloodbath
Copy link
Member Author

Uhh one example could be nvim-nio which recently got an update and it's one of our dependencies.

The rocks.toml looks something like this after running :Rocks update:

[plugins]
# .....
nvim-nio = "1.6.0"

If you remove the newly added nvim-nio entry nothing happens, so it's not something that can be reproduced over and over again so I guess testing will be hard for this one 🫠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants