-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ensure plugin runtime paths are available before rocks initialises #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
mrcjkb
force-pushed
the
site-symlinks
branch
4 times, most recently
from
April 22, 2024 17:47
acdc4df
to
931ffff
Compare
Let's get this merged and I'll look into deprecating |
Down to deprecate packadd as well. New changes look good to me! |
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, rocks.nvim maintains symlinks to the plugin runtime paths in
site/pack/luarocks/opt
.Because the symlinks are all in
opt
, they are available on the runtimepath before rocks.nvim initialises, but none of theplugin
,after/plugin
orftdetect
directories are sourced (rocks.nvim takes care of this for non-opt plugins).This brings with it some nice benefits:
colorscheme <scheme>
in their init.lua, as they might be used to from a traditional plugin manager (see Loading colorscheme (tokyonight.nvim) #212).autoload
directories of dependencies are available on the runtimepath, which means vimscript plugins can be installed as dependencies.Not yet implemented (TODO):
rocks.runtime.packadd
can probably be replaced by a call to Neovim's built-inpackadd
[needs triage].If this is the case, we can deprecate
:Rocks packadd
andrequire("rocks").packadd
:vim.deprecate("rocks.packadd", "vim.cmd.packadd", "3.0.0", "rocks.nvim")
.