Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sync): error when rocks.toml has no rocks or plugins entries #295

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix(sync): error when rocks.toml has no rocks or plugins entries #295

merged 1 commit into from
Apr 24, 2024

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Apr 24, 2024

Fixes #291

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited by mrcjkb

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

vhyrro
vhyrro previously approved these changes Apr 24, 2024
View reviewed changes
@mrcjkb mrcjkb enabled auto-merge (squash) April 24, 2024 22:36
@mrcjkb mrcjkb merged commit e74ffdd into master Apr 24, 2024
10 checks passed
@mrcjkb mrcjkb mentioned this pull request Apr 24, 2024
Merged
@mrcjkb mrcjkb deleted the sync branch April 24, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhyrro vhyrro vhyrro left review comments

@NTBBloodbath NTBBloodbath Awaiting requested review from NTBBloodbath NTBBloodbath is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] :Rocks sync fails when there are no plugins in rocks.toml
2 participants
@mrcjkb @vhyrro