Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support template_string as test name #47

Open
sassanh opened this issue Nov 10, 2022 · 2 comments · May be fixed by #112
Open

Support template_string as test name #47

sassanh opened this issue Nov 10, 2022 · 2 comments · May be fixed by #112

Comments

@sassanh
Copy link

sassanh commented Nov 10, 2022

Tests written as test(`Some test`) are not supported (the test name is written in back ticks), it would be nice if we can support them.
@benlubas
Copy link
Contributor

benlubas commented Apr 7, 2023

Additionally, it("has `backticks` in other quotes") doesn't work either

@sassanh sassanh changed the title Supper template_string as test name Support template_string as test name Apr 21, 2023
conermurphy added a commit to conermurphy/neotest-jest that referenced this issue Mar 28, 2024
@conermurphy
fix(nvim-neotest#47): unable to detect tests using backticks
d1b9e23 
Fixes nvim-neotest#47
conermurphy added a commit to conermurphy/neotest-jest that referenced this issue Mar 28, 2024
@conermurphy
fix(nvim-neotest#47): unable to detect tests using backticks
76d7569 
Fixes nvim-neotest#47
@conermurphy conermurphy linked a pull request Mar 28, 2024 that will close this issue
Open
@conermurphy
Copy link
Contributor

I just encountered the same issue, just raised a PR to fix it (#112), seems to now work all okay locally.

With these changes should now detect tests like:

describe(`some describe`, () => {})
describe("`some describe` in a string", () => {})
it(`some it`, () => {})
it("`some it` in a string", () => {})

Shows up in the summary page like the below

some describe
`some describe` in a string
some it
`some it` in a string

@conermurphy conermurphy mentioned this issue Apr 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#47): unable to detect tests using backticks conermurphy/neotest-jest
3 participants
@sassanh @conermurphy @benlubas