fix(picker): set current_line state earlier
#3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestrew
force-pushed
the
fix/set-current-line
branch
from
29a22d0
to
ca28328
Compare
Sets the `current_line` global state earlier in the event loop rather than in `get_results_completor`. This makes it safer to access `current_line` earlier (eg. for building an entry).
jamestrew
force-pushed
the
fix/set-current-line
branch
from
ca28328
to
2baecb7
Compare
|
Thanks for the quick patch! I'll run this branch in my config as well. |
|
I haven't come across any issues myself but I wanna double check with @Conni2461 before merging this. Maybe there's some good reason not obvious to me for why we previously set |
|
I've been running this branch for a month now with no issues. Is there anything I can do to help get it merged? For some more context, I'm using this feature to implement a limited depth file tree browser that switches to default paths when you start typing. Screen.Recording.2024-05-15.at.7.08.03.PM.movextensions = {
file_browser = {
path_display = function(opts, path)
local action_state = require("telescope.actions.state")
local current_line = action_state.get_current_line()
if current_line == "" and opts.finder.files and path:match("%w+/%w+") then
return path:gsub("^.+/", " ")
else
return path
end
end,
wrap_results = false,
depth = 2,
},
} |
|
ok let's merge this then before I forget about it. |
Conni2461
pushed a commit
that referenced
this pull request
May 20, 2024
Sets the `current_line` global state earlier in the event loop rather than in `get_results_completor`. This makes it safer to access `current_line` earlier (eg. for building an entry). (cherry picked from commit 52f5001)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the
current_lineglobal state earlier in the event loop rather than inget_results_completor. This makes it safer to accesscurrent_lineearlier (eg. for building an entry).closes #3051
I'm not super confident this is safe to do without some unintended side effects. I've experienced some finicky race conditions with the
picker:_get_promptbefore so I'll use this branch for a bit.