Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display git status in signcolumn #553

Closed
mrossinek opened this issue Aug 9, 2021 · 5 comments · Fixed by #1242
Closed

Display git status in signcolumn #553

mrossinek opened this issue Aug 9, 2021 · 5 comments · Fixed by #1242

Comments

@mrossinek
Copy link

As I understand things right now, you leverage the signcolumn to display the lsp diagnostic status for files with potential issues.
While I like the idea of that, I'd rather use the signcolumn to display the git status information (thereby also preventing things like #72). Is that something you have thought about or would be willing to implement?

An additional cherry on top would be to have a configuraiton option whether git status signs are placed:

  • to the right of file/folder names
  • to the left of file/folder names
  • in the sign column

Maybe you could leverage the same implementation to make the lsp diagnostic symbol location configurable in the same way? 🤔

@kyazdani42
Copy link
Member

Good idea I guess, but it would add quite a lot of code and I'm currently doing a big rewrite of the codebase so we will do that after :)

@sethen
Copy link

sethen commented Aug 16, 2021

I second that it would be rad if we could pick where the git status icons go... Personally I would like them to the right of the directory

@kyazdani42
Copy link
Member

it has been asked many times, the renderer needs a bit of a rewrite because it's quite messy as it is.

@alex-courtis
Copy link
Member

I like the sign column idea.

@kyazdani42
Copy link
Member

yes, that's why the renderer needs a big rewrite 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants