Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code typo ? #1

Closed
taki0112 opened this issue Apr 16, 2018 · 1 comment
Closed

code typo ? #1

taki0112 opened this issue Apr 16, 2018 · 1 comment

Comments

@taki0112
Copy link

taki0112 commented Apr 16, 2018 •
edited
Loading

code

c_b_recon, s_a_recon = self.gen_a.encode(x_ba)

-> c_a_recon, s_a_recon = self.gen_a.encode(x_ba)

I think this is right.

What do you think ?
@taki0112
Copy link
Author

taki0112 commented Apr 16, 2018 •
edited
Loading

oops
I think you are right
sorry

Because x_ba was created with content = domain B, style = domain A,

So when you encode it, you have to come up with the original content = domainB, style = domainA
For this reason, I think your code is right. Is that right ?

@taki0112 taki0112 reopened this Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taki0112