Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad quality using official Neuralangelo compared to sdfstudio Implementation #25

Open
xiemeilong opened this issue Aug 16, 2023 · 8 comments

Comments

@xiemeilong
Copy link

xiemeilong commented Aug 16, 2023

I obtained very good results using neuralangelo in sdfstudio, but for the same image data, the results obtained using the official neuralangelo implementation were like this.
image

results using neuralangelo in sdfstudio
image

@mli0603
Copy link
Collaborator

mli0603 commented Aug 16, 2023

Hi @xiemeilong

Thanks for reporting this. This is indeed odd and unexpected. To narrow down the problem, could you help by providing the following information?

  • Do you use the same preprocessing steps for both implementations? If not, could you point me to the preprocessing step in sdfstudio?
  • Can you share configs/commands for both implementations? This helps me to compare the hyperparameters if there are differences.
  • Can you share the mesh extraction command for both implementations?

Thank you!

@chenhsuanlin
Copy link
Contributor

Hi @xiemeilong, in addition to the above @mli0603 mentioned, we also have a fix (#41) on the scripts. If you were extracting the mesh from an earlier checkpoint, please pull again and let us know if the issue persists. Thanks!

@zz7379
Copy link

zz7379 commented Aug 21, 2023

same poor mesh too

@xiemeilong
Copy link
Author

@chenhsuanlin It still does not work with the latest code.

@mli0603

preprocessing cmd in neuralangelo:

bash projects/neuralangelo/scripts/run_colmap.sh ../data/neuralangelo/tangtou  
python3 projects/neuralangelo/scripts/convert_data_to_json.py --data_dir ~/labs/data/neuralangelo/tangtou/dense  --scene_type outdoor
python3 projects/neuralangelo/scripts/generate_config.py --experiment_name tangtou --data_dir ~/labs/data/neuralangelo/tangtou/dense/  --auto_exposure_wb

preprocessing cmd in sdfstudio:

ns-process-data images --data tangtou  --output-dir nerfstudio/tangtou --num-downscales 2

train command in neuralangelo:

torchrun --nproc_per_node=1 train.py   --logdir=logs/my/tangtou --config=/home/xxx/labs/neuralangelo/projects/neuralangelo/configs/custom/tangtou.yaml     --show_pbar

train command in sdfstudio, I am using the same test prompts as the author of sdfstudio, not the pure neuralangelo algorithm:

ns-train bakedangelo --machine.num-gpus 1 --pipeline.model.level-init 8 --trainer.steps-per-eval-image 5000  --pipeline.datamanager.train-num-rays-per-batch 2048 --pipeline.datamanager.eval-num-rays-per-batch 512 --pipeline.model.sdf-field.use-appearance-embedding True --pipeline.model.background-color white --pipeline.model.sdf-field.bias 0.1 --pipeline.model.sdf-field.inside-outside False --pipeline.model.background-model grid  nerfstudio-data   --data data/nerfstudio/tangtou

extract command in neuralangelo:

torchrun --nproc_per_node=1 projects/neuralangelo/scripts/extract_mesh.py \
    --config=/home/xxx/labs/neuralangelo/projects/neuralangelo/configs/custom/tangtou.yaml \
    --checkpoint=logs/my/tangtou/epoch_01736_iteration_000500000_checkpoint.pt \
    --output_file=tangtou.ply \
    --resolution=2048 \
    --block_res=128 

extract command in sdfstudio:

ns-extract-mesh --load-config  outputs/nerfstudio-tangtousimple/bakedangelo/2023-07-30_123845/config.yml  --output-path meshes/tangtousimple.ply --resolution 2048 --marching_cube_threshold 0.001 --create_visibility_mask True

@chenhsuanlin
Copy link
Contributor

@xiemeilong @zz7379 we have pushed an update to main yesterday that fixed a checkpoint issue which may be related. Could you pull and try running the pipeline again? Please let me know if there are further issues with the latest code.

@xiemeilong
Copy link
Author

@chenhsuanlin The latest version still doesn't work.

@iam-machine
Copy link

@xiemeilong Hi :) Do you still have good results in Neuralangelo in sdfstudio and bad results in official Neuralangelo?

@xiemeilong
Copy link
Author

xiemeilong commented Sep 8, 2023

@iam-machine I did not do any more testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants