Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with polarization direction #115

Closed
zhengxf99 opened this issue Apr 7, 2023 · 1 comment
Closed

Problem with polarization direction #115

zhengxf99 opened this issue Apr 7, 2023 · 1 comment

Comments

@zhengxf99
Copy link

Hi Sionna team,

If my understanding is correct, there is a bug with polarization direction calculation in current version.

In line 452 of antenna.py,
slant_angle = 0 if polarization == "VH" else -PI/4
which should be,
slant_angle = 0 if polarization_type == "VH" else -PI/4

Thanks

@jhoydis
Copy link
Collaborator

jhoydis commented Apr 7, 2023

Good catch! This is indeed a bug. It will be corrected in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants