Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug?] sphere harmonics encoding's backward function #25

Closed
ashawkey opened this issue Jan 21, 2022 · 3 comments
Closed

[bug?] sphere harmonics encoding's backward function #25

ashawkey opened this issue Jan 21, 2022 · 3 comments

Comments

@ashawkey
Copy link

Hi,
In this line, stride is set to sh_degree, but shouldn't it be sh_degree * sh_degree?
@Tom94
Copy link
Collaborator

Tom94 commented Jan 21, 2022 •
edited

Thank you very much for catching that, you're 100% correct. Fix incoming.

(For instant-ngp, fixing this may very well contribute to better extrinsics / distortion optimization. Those are the only place, where the directionally varying gradient of the encoding is currently used.)

@Tom94
Copy link
Collaborator

Tom94 commented Jan 21, 2022

Fixed by 8575542

@Tom94 Tom94 closed this as completed Jan 21, 2022
@ashawkey
Copy link
Author

Got it, thanks for your quick reply!

@Tom94 Tom94 mentioned this issue Jan 21, 2022
Closed
@lambdald lambdald mentioned this issue Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tom94 @ashawkey