Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does sample code with one-blob encoding still work? #46

Closed
shocker-0x15 opened this issue Feb 20, 2022 · 2 comments
Closed

Does sample code with one-blob encoding still work? #46

shocker-0x15 opened this issue Feb 20, 2022 · 2 comments

Comments

@shocker-0x15
Copy link

Thanks for sharing the great library.

I tried the sample code using the image in the data directory and have confirmed the program instantly learns the image with "HashGrid" encoding (config_hash.json). However, with one-blob encoding (config_oneblob.json), the program constantly produces completely black images.

I tried bisection to find with which revision this issue occurred and it seems c88c1dcf81d89e0b4217ae4aaac34c963bf29d86 (The first revision for v1.2).

Does the sample with one-blob encoding still work in other environments other than me?

My environment:
Windows 10 21H2 (19044.1526)
Visual Studio Community 2022 (17.1.0)
cmake 3.21.4
RTX 3080 10GB
CUDA 11.6
Driver: 511.79

Thanks,

@Tom94
Copy link
Collaborator

Tom94 commented Feb 20, 2022

Hi there, thanks for reporting this!

While everything works fine on my machine (Windows, WSL2, as well as native Linux), other users reported similar issues in the past.

There's a (seemingly unrelated) fix to this problem -- I suspect something funky in the underlying codegen -- which in the past always led to slightly worse performance in the case of 128-neurons wide neural networks.

But, and this stumps me, the fix in question improved performance by ~10% when I tried it just now! I'm not going to question it (the fix simplifies the code considerably), push it to master, and merely ask you to pull to confirm it works now.

@shocker-0x15
Copy link
Author

shocker-0x15 commented Feb 20, 2022

Wow, thanks for your quick response!
I pulled the latest master 1e235e8 and have confirmed it works perfectly with one-blob encoding.

I appreciate your quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants