Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why don't you check if node-v0.x.x.tar.gz exists first? #72

Closed
yuest opened this issue Oct 9, 2011 · 2 comments
Closed

Why don't you check if node-v0.x.x.tar.gz exists first? #72

yuest opened this issue Oct 9, 2011 · 2 comments
Assignees
Labels
feature requests I want a new feature in nvm!

Comments

@yuest
Copy link

yuest commented Oct 9, 2011

If there is a node-v0.x.x.tar.gz in current directory, I think you can just use it.

@Port3M5
Copy link

Port3M5 commented Oct 9, 2011

It could have potentially not be completely downloaded. By downloading it freshly it (hopefully) ensures that the file should not be corrupt.

That is fine as default behaviour but maybe if a flag was added like --no-download that allowed you to do that, it could be potentially be a very helpful tool.

@ljharb ljharb added the pull request wanted This is a great way to contribute! Help us out :-D label Apr 7, 2015
@ljharb
Copy link
Member

ljharb commented Sep 3, 2016

Finally, this has been achieved in #1204.

If the file exists, and the checksum can be computed, and matches, it is used - otherwise it's downloaded from the server. nvm cache clear removes all cached tarballs.

@ljharb ljharb closed this as completed Sep 3, 2016
@ljharb ljharb removed the pull request wanted This is a great way to contribute! Help us out :-D label Sep 3, 2016
@ljharb ljharb self-assigned this Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature requests I want a new feature in nvm!
Projects
None yet
Development

No branches or pull requests

2 participants