Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P02s phosphorus BODCNVS-1722 #36

Closed
MeganAnneFrench opened this issue Mar 7, 2023 · 8 comments
Closed

P02s phosphorus BODCNVS-1722 #36

MeganAnneFrench opened this issue Mar 7, 2023 · 8 comments

Comments

@MeganAnneFrench
Copy link

MeganAnneFrench commented Mar 7, 2023

Hi,
I have attached an Excel file with some suggested changes to P02 and P36 codes relating to P01s for phosphorus (based on the file created by Dick in November 2022 - the non-shaded columns). The yellow shaded columns show the suggested changes and the grey shaded columns are notes. The suggested P02 change relates to a deprecated code: "Phosphorus concentrations in sediment DEPRECATED", but it is unclear why this was deprecated. As the other main nutrient-type element, nitrogen has P02s of "Nitrogen concentrations in sediment" (inorganic nitrogen is mapped here), "Dissolved total and organic nitrogen concentrations in the water column", and "Particulate total and organic nitrogen concentrations in the water column", whereas the active P02s for phosphorus are just "Dissolved total or organic phosphorus concentration in the water column" and "Particulate total and organic phosphorus concentrations in the water column". Phosphorus and nitrogen should be treated in the same way.
Megan
P02s phosphorus.xlsx

@mmolinajack
Copy link

The phosphorous should be considered similar to the nitrogen and now there are inconsistencies in this sense.

@MeganAnneFrench
Copy link
Author

MeganAnneFrench commented Mar 7, 2023 via email

@gwemon
Copy link
Contributor

gwemon commented Apr 21, 2023

Investigating why http://vocab.nerc.ac.uk/collection/P02/current/PXSD/ was deprecated. I agree that it does not look right.

@gwemon
Copy link
Contributor

gwemon commented Apr 21, 2023

@MeganAnneFrench As you said, we do have Nitrogen concentrations in sediment so one would expect an equivalent category for phosphorus. I can't think of or track back to a reason why PXSD was deprecated (it was deprecated in 2012) so I have re-instated it as it does not really make sense to have it deprecated and replacedBy MIN .

@MeganAnneFrench
Copy link
Author

MeganAnneFrench commented Apr 21, 2023 via email

@gwemon
Copy link
Contributor

gwemon commented Apr 21, 2023

I have also reviewed the mappings and all "concentration of phosphorus in sediment" codes now point to tp PXSD and not RMIN or MTSD.
The only "phosphorus" related codes I kept under RMIN are the "geological" phosphorus because these would not belong to "eutrophication/fertilisation" theme. These codes are:
GEOLST22 Concentration of total phosphorus {total_P CAS 7723-14-0} per unit dry weight of geological sample
MAJO0010 Proportion of phosphorus (expressed as phosphorus pentoxide) {P_as_P2O5 CAS 7723-14-0} per unit weight of sediment
MAJO0021 Proportion of phosphorus (expressed as phosphorus pentoxide) {P_as_P2O5 CAS 7723-14-0} per unit weight of rock
MAJO0034 Proportion of phosphorus (expressed as phosphorus pentoxide) {P_as_P2O5 CAS 7723-14-0} per unit weight of geological sample

The changes will be live after our overnight refresh.

@gwemon gwemon changed the title P02s phosphorus P02s phosphorus BODCNVS-1722 Apr 21, 2023
@gwemon
Copy link
Contributor

gwemon commented May 18, 2023

I think this can now be closed. Is that right @MeganAnneFrench ?

@MeganAnneFrench
Copy link
Author

MeganAnneFrench commented May 18, 2023 via email

@gwemon gwemon closed this as completed May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants