Using --noserver picks up no issues and returns Passed even when there are issues

[colossusb]

Summary

Running with '--noserver' does not pick up issues yet everything appears Passed
This has been run on serveral different machines and always replicates as below.
Wondering if perhaps some CodeNarc update has broken this?

Might be related to #284 ?

To Replicate

1. Make some obvious error in your code
2. Run 'npm-groovy-lint ' to confirm the error is picked up
3. Run 'npm-groovy-lint --noserver' and witness the error is not picked up

Versions

npm-groovy-lint --version
GroovyLint: Successfully processed CodeNarc: 
CodeNarc version 3.1.0

npm-groovy-lint version 11.1.1

Embeds:
CodeNarc version 3.1.0
- Groovy version 3.0.9 (superlite)

OS's
Ventura
Linux

Example

me@mymachine my_folder % npm-groovy-lint ./vars/addSshAuthorizedKeys.groovy           
/Users/me/PycharmProjects/my_folder/vars/addSshAuthorizedKeys.groovy
  10    error    Unexpected input: '[\n        whoops_I_put_a_Bunch_of_Crap_in_My_Code\n        'publicKey'' @ line 10, column 9.  NglParseError           


npm-groovy-lint results in 1 linted files:
┌─────────┬───────────┬─────────────┐
│ (index) │ Severity  │ Total found │
├─────────┼───────────┼─────────────┤
│    0    │  'Error'  │      1      │
│    1    │ 'Warning' │      0      │
│    2    │  'Info'   │      0      │
└─────────┴───────────┴─────────────┘
Failure: 1 error(s) have been found 
 0 warning(s) have been found 
 0 info(s) have been found
me@mymachine my_folder % npm-groovy-lint ./vars/addSshAuthorizedKeys.groovy --noserver

npm-groovy-lint results in 0 linted files:
┌─────────┬───────────┬─────────────┐
│ (index) │ Severity  │ Total found │
├─────────┼───────────┼─────────────┤
│    0    │  'Error'  │      0      │
│    1    │ 'Warning' │      0      │
│    2    │  'Info'   │      0      │
└─────────┴───────────┴─────────────┘

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

[yermulnik]

Same here 😢

> npm ls -g
/home/giermulnik/.npm-global/lib
└── npm-groovy-lint@11.1.1

> npm-groovy-lint --noserver ./test.jenkinsfile

npm-groovy-lint results in 0 linted files:
┌─────────┬───────────┬─────────────┐
│ (index) │ Severity  │ Total found │
├─────────┼───────────┼─────────────┤
│    0    │  'Error'  │      0      │
│    1    │ 'Warning' │      0      │
│    2    │  'Info'   │      0      │
└─────────┴───────────┴─────────────┘

[tbroyer]

Running into the same problem as well. This is indeed #284 and the analysis here is correct: this code needs to be applied in callCodeNarcJava as well as callCodeNarcServer:

npm-groovy-lint/lib/codenarc-caller.js

Lines 62 to 72 in 6d7806b

	// Remove "" around values because they won't get thru system command line parser
	const codeNarcArgsForServer = this.codenarcArgs.map(codeNarcArg => {
	if (codeNarcArg.includes('="') || codeNarcArg.includes(':"')) {
	codeNarcArg = codeNarcArg
	.replace('="', "=")
	.replace(':"', ":")
	.replace(/ /g, "%20");
	codeNarcArg = codeNarcArg.substring(0, codeNarcArg.length - 1);
	}
	return codeNarcArg;
	});

Workaround

Pass dummy arguments before and after your file list:

$ npm-groovy-lint --noserver dummy ./vars/addSshAuthorizedKeys.groovy dummy

[tbroyer]

And/or maybe npm-groovy-lint should not include quotes in the -includes parameter when it builds it?

npm-groovy-lint/lib/codenarc-factory.js

Line 117 in 6d7806b

result.codenarcArgs.push(`-includes="${patternsFinal}"`);

[nvuillam]

Would anyone here submit a PR with the fix ? :)

[nvuillam]

This problem might be solved in v13.0.0, do you still have it ?

[tbroyer]

I confirm this now works as expected with 13.0.0.

[nvuillam]

Thanks a lot for your feedback :)