Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide overload of wrap_results that does not need a result_map #99

Open
ryanmrichard opened this issue Jul 15, 2019 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@ryanmrichard
Copy link
Member

PropertyType<T>::wrap_results takes two arguments the results map that it is adding the results to and the results to add to the map. The motivation for taking the results map is that it supports concatenation of multiple property types' results into a single result map; however, when there is only a single property type (or equivalently it's the call to the first of several property types) this leads to code like auto rv = results() to make the initial result map. We should create an overload of wrap_results that does not require a results_map.

Note: this will likely require SFINAE to pull off as the resulting signature will be fully templated.

@ryanmrichard ryanmrichard added the good first issue Good for newcomers label Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant