Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number format exception when scraping #7

Closed
hanifdean opened this issue Nov 9, 2018 · 6 comments
Closed

Number format exception when scraping #7

hanifdean opened this issue Nov 9, 2018 · 6 comments
Assignees
@nwihardjo

Comments

@hanifdean
Copy link
Collaborator

Can you take a look at this? I think there's a bug with dealing with a different number format (i.e. 2,300 as compared to 2300)

screen shot 2018-11-09 at 4 20 49 pm
@hanifdean hanifdean assigned hanifdean and nwihardjo and unassigned hanifdean Nov 9, 2018
@hanifdean
Copy link
Collaborator Author

#uptoyou #lol

@hanifdean
Copy link
Collaborator Author

^ iseng lol

@nwihardjo
Copy link
Owner

nwihardjo commented Nov 9, 2018 •
edited

is this bug caused by ee2a0a3 ?

@hanifdean
Copy link
Collaborator Author

I don't think so, but it happens on some items only. It happened when I searched "watch", but it didn't happen when I searched stuff like iPhone. Probably happened on more luxurious items because the prices were higher so it had "," to separate the price (i.e. 2,999).

@nwihardjo
Copy link
Owner

Yep, it should be fixed by ee2a0a3 Try merging with the most recent commit in master, lmk if the problem still persists.

@hanifdean
Copy link
Collaborator Author

thanks yo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nwihardjo nwihardjo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nwihardjo @hanifdean