Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing binary when installing nwjs using pnpm #181

Closed
2 tasks done
thisjt opened this issue Jun 21, 2024 · 2 comments · Fixed by #183
Closed
2 tasks done

Missing binary when installing nwjs using pnpm #181

thisjt opened this issue Jun 21, 2024 · 2 comments · Fixed by #183

Comments

@thisjt
Copy link

thisjt commented Jun 21, 2024

Issue Type

(Issue moved from nwjs/nw.js#8193)

  • Bug Report
  • Successfully reproduced against the latest version of NW.js?

Current/Missing Behavior

When we install the sdk version of nw and then run it through the console, we are getting an error of missing binary instead of launching the application normally.

Expected/Proposed Behavior

Nw runs normally and has no issues.

Additional Info

It seems that it is still attempting to run the regular nwjs production version instead of the sdk one even though in the postinstall script it downloaded and extracted the sdk one.

image

image

image

Workaround for this one is to rename nwjs-sdk-v0.88.0-win-x64 to nwjs-v0.88.0-3-win-x64 so that the sdk binary is run.

@ayushmanchhabra
Copy link
Collaborator

ayushmanchhabra commented Jun 21, 2024

@thisjt Please try v0.88.0-4. If you face the same issue, please ping here and I'll reopen it.

@thisjt
Copy link
Author

thisjt commented Jun 22, 2024

@ayushmanchhabra all good. It's now working on my end. Thanks for the fast fix!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants