Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some serious issues with windows (MacOS X, 0.8.4) #1510

Closed
thenitai opened this issue Jan 25, 2014 · 2 comments
Closed

Some serious issues with windows (MacOS X, 0.8.4) #1510

thenitai opened this issue Jan 25, 2014 · 2 comments
Assignees

Comments

@thenitai
Copy link

Been testing windows today all day and had a lot of crashes.

Window called from a submenu
I created a submenu that opens one of my pages. Code is:

var new_win = gui.Window.open('about.html', {
position: 'center',
width: 500,
height: 400,
focus: true,
resizable: false,
toolbar: false
});
new_win.on('close', function() {
this.hide();
this.close(true);
});

On the about page I have a link as simple as: window.close();

What happens is that the window closes, but the next time I open the window again node-webkit completely crashes. I've tried various different ways, but nothing seems to work.

I then went ahead and added the below function within the about page itself and calling this function with the "close" link:

function closeAbout(){
var gui = require('nw.gui');
var win = gui.Window.get();
win.hide();
}

While this helps, it only helps with a frameless window. As soon as the user would click on the close icon or uses a shortcut to close the window, note-webkit will crash on re-opening the window. In short, the close(true) argument seems to be the culprit here.

Main Window being closed with cmd+w
The second issue is that, on the Mac, you can use the shortcut "cmd + w" to close any window. Unfortunately, if I close a popup window with cmd+w I also have the option to close the main window. Once done, you loose the possibility to quit the application in general (the quit option is greyed out).

@ghost ghost assigned rogerwang Jan 27, 2014
@jamesmortensen
Copy link

Is it possible to edit the title and say that the issue is crashes and not be vague about what the issue is? I had to click the link to see what it's really about, and that sort of defeats the purpose of having a high-level issue list.

With that said, I was experiencing some crashes a few days ago and saw some information in the console logs, in the terminal. My crashing issues seemed to go away on their own, but you might consider including those as well here on this ticket.

Also, I haven't played around with this, but you can obtain and examine crash dumps: https://github.com/rogerwang/node-webkit/wiki/Crash-dump Hope this helps.

@tommoor
Copy link

tommoor commented Dec 17, 2014

Closing as no activity in 12 months, please reopen if you are still experiencing this issue.

@tommoor tommoor closed this as completed Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants