Windows Menu Creation

[gitchs]

I append a menu shortcut test case in my repo. It works well on Linux and OSX.
But on Windows platform, the case does not work well, but if I move codes in line 22, line 24 and line 19 to the end of the script, it works.

I think the menu should could be create and append at any place but not with a specific order. Since there is a workaround method , I will continue my porting work first.
@rogerwang Should I look back later and fix it(I think it is a bug.)?

Here is the workaround code. The only difference is the last 3 line JavaScript codes' position

---

        var gui = require('nw.gui');
        var win = gui.Window.get();
        var menubar = new gui.Menu({ type: 'menubar' });

        var menubar_file = new gui.MenuItem({"label":"File"});
        var file_menu = new gui.Menu();
        var file_quit_item = new gui.MenuItem({
          "label":"Quit",
          "click":function(){
            gui.App.quit();
          },
          "key":"q",
          "modifiers":"ctrl"
        });
        var file_info_item = new gui.MenuItem({
          "label":"Info",
          "click":function(){
            console.log("hello world");
          },
          "key":"i",
          "modifiers":"ctrl+alt"
        });
        file_menu.append(file_info_item);
        file_menu.append(file_quit_item);

        var file_about_item = new gui.MenuItem({
          "label":"About us!",
          "key":"U",
          "modifiers":"ctrl",
          "click":function(){
            console.log("About Info");
          }
        });
        file_menu.insert(file_about_item,0);
        menubar_file.submenu = file_menu;
        menubar.append(menubar_file);
        win.menu = menubar;  

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[jmdobry]

I've noticed that in order for my menus to work on windows I have to build them in the opposite order that I build them for Mac.

[felicienfrancois]

The workaround code does not work for me.
Hotkeys are not displayed in the menu.

Node-webkit 0.10.5 - Windows 8.1

[tshinnic]

I believe it is the case that all the 'instructions' - what the menu contains and how it is to be displayed - must be setup in the object data structures before you do the win.menu = menubar; action. It seems like setting win.menu must be the last thing you do. Any further changes to the data structures are not noticed by the nwjs code. For sure when I start moving the win.menu = ... around, then nwjs 'sees' fewer and fewer menu items!

And yes I'm testing on Windows and haven't tried Linux yet. Whether the Windows implementation has stricter requirements would be a useful thing for Roger or someone else to comment on.

[mnemanja]

I had this issue, and applying the @tshinnic's approach solved the menu item not showing, or additional changes to it not being applied. So on a build nwjs-v0.12.3-win-x64 the win.menu = ...; has to be the last line after that block's changes.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.