Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls.connect({socket:socket}) doesnt work #2484

Closed
ayapi opened this issue Oct 21, 2014 · 1 comment
Closed

tls.connect({socket:socket}) doesnt work #2484

ayapi opened this issue Oct 21, 2014 · 1 comment

Comments

@ayapi
Copy link

ayapi commented Oct 21, 2014

I face a problem with tls.connect(options) on node-webkit v0.10.5 win32.

var net = require('net');
var tls = require('tls');
var socket = net.createConnection(config.port, config.host);
var tls_options = {
  socket: socket, rejectUnauthorized: false
};

For example, the following code cause the app to raise ENOTCONN or crash with [FATAL:render_process_host_impl.cc(436)]Check failed: !g_exited_main_message_loop

var tls_socket = tls.connect(tls_options, function(){
  console.log('handshake');
});

This problem doesnt occur on node-webkit v0.8.6.
And it doesnt on Node.js v0.11.13, too.
But It occur on node-webkit v0.10.5.

In this connection, the following can work well on node-webkit v0.10.5.

var tls_socket;
socket.once('connect', function(){
  tls_socket = tls.connect(tls_options, function(){
    console.log('handshake');
  });
});

I think modules using tls(such as node-mongodb-native) are affected by it.
Is this node-webkit's bug?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@nwjs-bot
Copy link

This should be working with latest version now.

In 0.13 we changed to an optimized architecture so more features can be supported, see http://nwjs.io/blog/whats-new-in-0.13/ and it's good for keeping up with Chromium upstream -- we released with Node.js v6.0 and new Chromium versions within 1 day after upstream release.

The new version would fixed many issues reported here and we're scrubbing them. This issue is closed as we believe it should be fixed. Please leave a message if it isn't and we'll reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants