new-win-policy prevent default #2926

FezVrasta · 2015-01-12T20:39:41Z

I'm trying to access Google Inbox using a node-webkit app and I/m trying to make my app open every link on the default browser listening for new-win-policy, the problem is that when I click on a link it gets opened on the default browser but it gets even opened on a new node-webkit window.

Is there a way to call some kind of preventDefault() on this event?

This is the very simple app:

<html>
  <head>
    <title>Google Inbox</title>
    <style>
      body {
        margin: 0px;
        overflow: hidden;
      }
      iframe {
        border: 0;
        width: 100%;
        height: 100%;
      }
    </style>
  </head>
  <body>
    <iframe src="https://inbox.google.com" nwdisable nwfaketop></iframe>
    <script>
      var gui = require('nw.gui');
      var win = gui.Window.get();
      win.on('new-win-policy', function (frame, url, policy) {
        gui.Shell.openExternal(url);
        policy.ignore();
      });
    </script>
  </body>
</html>

Thanks!

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

The text was updated successfully, but these errors were encountered:

marcfowler · 2015-01-13T00:08:53Z

I've tried that code and it works for me - it opens the URL in my default browser (Chrome) and nothing changes in the node-webkit window.

What happens for you? (I'm on OSX 10.10.1 and node-webkit 0.11.5)

FezVrasta · 2015-01-13T07:50:32Z

Every time I click on an URL it gets opened on both the default browser and a new node-webkit window.

FezVrasta · 2015-01-13T08:39:18Z

Here the DMG of my app:
https://drive.google.com/file/d/0B2X_eiwb0UlWN2NJRmpsb2tzc2M/view?usp=sharing

FezVrasta · 2015-01-15T08:30:00Z

Any update?

tommoor · 2015-01-15T16:29:33Z

Try

win.on('new-win-policy', function(frame, url, policy){
  policy.forceNewWindow();
});

FezVrasta · 2015-01-15T17:02:51Z

with it two node-webkit windows get opened

tommoor · 2015-01-18T17:58:53Z

It works for me on Mac, which platform are you using / have you tested on?

FezVrasta · 2015-01-18T18:02:23Z

Yosemite

Joblytics-io · 2015-01-23T12:03:43Z

I have the same problem on windows 7, NW 0.11.6.

It happens just on gmail.com with elements targer="_blank" (links in linkedin.com email's is best to reproduce)
I override gmail's window.open to this.

 window.open=function(){console.log(arguments)};

This is mi new-win-policy

win.on('new-win-policy', function(frame, url, policy){
  policy.ignore();
});

But the window is still created.
It works as expected on other sites.

Joblytics-io · 2015-01-26T09:31:51Z

The problem is in simulating javascript click on element with target _blank.
Here is web page loaded in iframe to reproduce problem.

<html>
    <script>
        function openTest (url){
            var a = document.createElement("a");
            a.target = "_blank";
            a.href = url;
            a.click()
        }
    </script>
    <button onclick="openTest('http://google.com')">Create Window</button>
</html>

Event new-win-policy did not call, but the window is still created.

win.on('new-win-policy', function(frame, url, policy){
  policy.ignore();
});

loretoparisi · 2015-11-10T01:03:18Z

I confirm that having an element like

<a href="http://about.musixmatch.com" target="_blank" data-reactid=".orogdvcw.0.2.1.0.2.0">Apps</a>

the

var eventsNewWinPolicy = function(frame, url, policy) {
      console.log("navigate to "+url);
      policy.ignore();
      gui.Shell.openExternal( url );
    };

will only work once, then the policy ignore will not work, and a new window will be opened.

VoidVolker · 2016-09-09T08:36:24Z

will only work once, then the policy ignore will not work, and a new window will be opened.

Same problem in 17.1: it work only once and then not working at all.

loretoparisi · 2016-09-09T08:47:01Z

@VoidVolker 👍

rogerwang · 2016-09-13T05:34:51Z

@VoidVolker the following always works for me with 0.17.1:

<html>
<head>
<title></title>
<script>
var win = nw.Window.get();
win.on('new-win-policy', function(frame, url, policy) { 
  console.log("new-win-policy called: " + url); 
  policy.ignore();
});
</script>
</head>
<body>
<a href="target.html" target="_blank">new window</a>
</body>
</html>

VoidVolker · 2016-09-13T08:04:51Z

Yes, for me too. But place a into new window page - and you will see, when user click link into this new window. Then it stop working.

rogerwang · 2016-09-13T08:49:56Z

Are you suggesting it stops working in the new window? That works for me too. Please upload a full sample.

Here is mine:

index.html

<html>
<head>
<title></title>
<script>
var win = nw.Window.get();
win.on('new-win-policy', function(frame, url, policy) { 
  console.log("new-win-policy called in main win: " + url); 
  //policy.ignore();
});
</script>
</head>
<body>
<a href="target.html" target="_blank">new window</a>
</body>
</html>

target.html

<!DOCTYPE html>
<html>
<head>
    <meta charset="utf8">
    <title></title>
<script>
var win = nw.Window.get();
win.on('new-win-policy', function(frame, url, policy) { 
  console.log("new-win-policy called: " + url); 
  policy.ignore();
});
</script>
</head>
<body>
<p>t1</p>
<a href="t2.html" target="_blank">new window 2</a>
</body>
</html>

rogerwang · 2016-09-18T01:16:52Z

close until more information is provided.

FezVrasta · 2016-09-18T02:01:48Z

really? LOL

better use Electron at this point if this is the professionality here 😓

tommoor added bug cant-reproduce labels Jan 18, 2015

Joblytics-io mentioned this issue Jan 26, 2015

New-win-policy handler is not called #3006

Closed

rogerwang removed the cant-reproduce label Apr 11, 2016

rogerwang self-assigned this Sep 9, 2016

rogerwang added the test-todo label Sep 13, 2016

rogerwang closed this as completed Sep 18, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new-win-policy prevent default #2926

new-win-policy prevent default #2926

FezVrasta commented Jan 12, 2015

marcfowler commented Jan 13, 2015

FezVrasta commented Jan 13, 2015

FezVrasta commented Jan 13, 2015

FezVrasta commented Jan 15, 2015

tommoor commented Jan 15, 2015

FezVrasta commented Jan 15, 2015

tommoor commented Jan 18, 2015

FezVrasta commented Jan 18, 2015

Joblytics-io commented Jan 23, 2015

Joblytics-io commented Jan 26, 2015

loretoparisi commented Nov 10, 2015

VoidVolker commented Sep 9, 2016 •

edited

loretoparisi commented Sep 9, 2016

rogerwang commented Sep 13, 2016

VoidVolker commented Sep 13, 2016

rogerwang commented Sep 13, 2016

rogerwang commented Sep 18, 2016

FezVrasta commented Sep 18, 2016

new-win-policy prevent default #2926

new-win-policy prevent default #2926

Comments

FezVrasta commented Jan 12, 2015

marcfowler commented Jan 13, 2015

FezVrasta commented Jan 13, 2015

FezVrasta commented Jan 13, 2015

FezVrasta commented Jan 15, 2015

tommoor commented Jan 15, 2015

FezVrasta commented Jan 15, 2015

tommoor commented Jan 18, 2015

FezVrasta commented Jan 18, 2015

Joblytics-io commented Jan 23, 2015

Joblytics-io commented Jan 26, 2015

loretoparisi commented Nov 10, 2015

VoidVolker commented Sep 9, 2016 • edited

loretoparisi commented Sep 9, 2016

rogerwang commented Sep 13, 2016

VoidVolker commented Sep 13, 2016

rogerwang commented Sep 13, 2016

rogerwang commented Sep 18, 2016

FezVrasta commented Sep 18, 2016

VoidVolker commented Sep 9, 2016 •

edited