Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirm(), alert() and prompt() dialog boxes show 'JavaScript' as their title #3430

Closed
DivineOmega opened this issue May 1, 2015 · 4 comments

Comments

@DivineOmega
Copy link

Using the confirm(), alert() and prompt() functions will bring up the appropriate dialog boxes as expected. However, they show JavaScript in the title. This seems inappropriate for the most common use of nw.js - building of desktop applications.

Would it be possible to remove the 'JavaScript' title from these dialog boxes, and either them it blank or replace it with the application name as defined in the the JSON application manifest?

I'd love to hear people's thoughts.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@ComSecNinja
Copy link

IMO it would also be okay if the window titles just showed the type of the dialog ("prompt" for prompt, "alert" for alert etc.). I agree that "JavaScript" is suboptimal.

@DivineOmega
Copy link
Author

@ComSecNinja That would make sense too.

If someone could point me in right direction, I'd be happy to submit a pull request for this. I'm having trouble locating where these dialog boxes' are generated.

@joshterrill
Copy link
Contributor

Maybe look in the shell_javascript_dialog.* files in /src/browser/. Just a guess.

@rogerwang
Copy link
Member

This should be working with latest version now.

In 0.13 we changed to an optimized architecture so more features can be supported, see http://nwjs.io/blog/whats-new-in-0.13/ and it's good for keeping up with Chromium upstream -- we released with Node.js v6.0 and new Chromium versions within 1 day after upstream release.

The new version would fixed many issues reported here and we're scrubbing them. This issue is closed as we believe it should be fixed. Please leave a message if it isn't and we'll reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants