Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kiosk mode osx still showing menu #5459

Closed
marcgfx opened this issue Nov 10, 2016 · 9 comments
Closed

kiosk mode osx still showing menu #5459

marcgfx opened this issue Nov 10, 2016 · 9 comments
Assignees

Comments

@marcgfx
Copy link

marcgfx commented Nov 10, 2016

I am using nwjs 0.17.6 as there are driver issues with chromium 54 webgl and some (my) nvidia cards.

I can't get rid of the osx-menu that appears when the mouse cursor moves to the top. as far as I understand, the menu should not appear in kiosk mode.

I've tried a lot of different variations, but none helped get rid of the menu (kiosk mode in config, kiosk from code, with/without setting fullscreen in config).

Calling kiosk mode from code at least made ⌘-Q work (does not work if done via config).

As this issue was around in 0.12 and the work-around was to call gui.Window.get().enterKioskMode() twice, I also tried this to no avail.

@marcgfx
Copy link
Author

marcgfx commented Nov 10, 2016

just as an addendum:
#1298

@ghostoy
Copy link
Member

ghostoy commented Nov 14, 2016

I'll look into this issue.

Before we fix it, you can try if it works by setting LSUIElement and LSUIPresentationMode in your Info.plist file.

@marcgfx
Copy link
Author

marcgfx commented Nov 15, 2016

thanks ghostoy. setting LSUIPresentationMode to 3 seems to do the trick!
the menu ⌘-Q stopped working after launch. maybe because I capture events?

@ghostoy
Copy link
Member

ghostoy commented Nov 16, 2016

@marcgfx Did you suggest that Cmd-Q doesn't work after calling enterKioskMode()? Does it work if you explicitly handle Cmd-Q with nw.Shortcut and invoke nw.App.quit() ? Does LSUIPresentationMode affect the function of Cmd-Q ?

@marcgfx
Copy link
Author

marcgfx commented Nov 16, 2016

I'm not sure. Sometimes it works (on startup it always works), in some cases it stops working. As It only can be executed once successfully, it's a bit hard to find the reason. I havent been able to pin-point when and how it happens. But I have the impression that me handling key-events in javascript might be preventing it from working. If I find out more, I will give you that information.

I personally would like Cmd-Q to continue to work, but maybe that is not what should be done.

edit: I did not try nw.Shortcut so far

@ghostoy
Copy link
Member

ghostoy commented Nov 29, 2016

@marcgfx Could you post a sample app to reproduce the Cmd-Q issue?

@marcgfx
Copy link
Author

marcgfx commented Nov 29, 2016

well I have a demo download for the game, where I experience Cmd-Q stopping to work after the game starts (still works in the menu). I've only just updated to Sierra and for some reason the zipped game no longer starts at all (it shows nw.js splash screen). I just checked it, rezipped and uploaded but after unzipping it no longer works on Sierra. The download can be found at http://falkenbrew.com

@ghostoy
Copy link
Member

ghostoy commented Dec 1, 2016

@marcgfx I've created another issue for tracking Cmd-Q issue #5516.

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants