Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparency click-through broken on 0.42.4 #7204

Closed
Blatman opened this issue Nov 9, 2019 · 5 comments
Closed

Transparency click-through broken on 0.42.4 #7204

Blatman opened this issue Nov 9, 2019 · 5 comments

Comments

@Blatman
Copy link

Blatman commented Nov 9, 2019

OSX 10.13.6 High Sierra
Regression - click through not working - is OK with 0.41.3

TransTest-simple.zip

Update: also noticed that since c. 0.34 onwards if frame: "false" exists in manifest then click/right-click is disabled eg: in attached test app if frame false is removed then right-click on the blue area (non-transparent) will give a context menu - this should also happen with frame set to false (maybe this should be a separate bug)
EDIT: don't worry about the Update: note - this is linked in with the drag/user select css settings so the only issue is the click-through

@rogerwang
Copy link
Member

CC @jtg-gg will you be free to check this? I didn't notice any rebase confilicts on this when upgrading from Chromium 77 to 78.

@jtg-gg
Copy link
Member

jtg-gg commented Nov 13, 2019

I've done some checking, the code looks ok, not sure why the click-through doesn't work

@jtg-gg
Copy link
Member

jtg-gg commented Nov 20, 2019

finally, after comparing the codes
@rogerwang please accept my pull request, and also merge to nw43

@rogerwang
Copy link
Member

great. Thanks!

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants