"Stop Sharing" button is missing

[shikhak]

Issue Type

Before opening an issue, please search and see if it has already been raised.

• Bug Report

• Feature Request

• Successfully reproduced against the latest version of NW.js?
  

Current/Missing Behavior

"Stop sharing " button is missing while sharing screen via webrtc site.

Expected/Proposed Behavior

"Stop sharing" button should be visible and user should be able to stop the screen sharing.

Additional Info

• Operating System: macoS : 13.3.1 (22E261)

• NW.js Version: v0.83.0

• Repro Link:

• Code snippet: ```
  nw.Window.open('https://webrtc.github.io/samples/src/content/getusermedia/getdisplaymedia', options, (win) => {

    });
  

- Crash report:

[sysrage]

I have also reproduced this in Windows 10.

[shikhak]

@ayushmanchhabra Shared this patch with me https://github.com/nwutils/nw-patches/blob/43b75a657fd877594d548a281cd02bc486a897d3/patches/chromium.patch#L8129-8206

By un-doing the following changes Stop sharing button is visible and working as expected:

File 1 :
Undo all the changes in file : nw/chromium/chrome/browser/media/webrtc/desktop_capture_devices_util.cc

File 2:
nw/chromium/chrome/browser/media/webrtc/desktop_capture_access_handler.cc

Only remove this change "extension->is_nwjs_app() ||" at two places (line no : 8098, 8106)

[sysrage]

@rogerwang please take a look and revert these changes unless they're needed for some reason.

[shikhak]

PR : https://github.com/nwjs/chromium.src/pull/165/files