Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build with gcc 4.7.0 #9

Closed
zcbenz opened this issue Jun 19, 2012 · 2 comments
Closed

Cannot build with gcc 4.7.0 #9

zcbenz opened this issue Jun 19, 2012 · 2 comments

Comments

@zcbenz
Copy link
Contributor

zcbenz commented Jun 19, 2012

Got this error when compiling:

In file included from seccompsandbox/library.cc:7:0:
seccompsandbox/library.h:159:46: error: ‘ssize_t’ has not been declared
make: *** [out/Debug/obj.target/seccomp_sandbox/seccompsandbox/library.o] Error 1
make: *** Waiting for unfinished jobs....

This bug was caused by not including unistd.h, which was not revealed by compiler until gcc 4.7.

Upstream chromium also had bugs of this type, see http://code.google.com/p/chromium/issues/detail?id=120724&can=1&q=GCC%204.7&colspec=ID%20Pri%20Mstone%20ReleaseBlock%20Area%20Feature%20Status%20Owner%20Summary

@zcbenz
Copy link
Contributor Author

zcbenz commented Jun 19, 2012

Got more errors after fixing this one:

In file included from ./ipc/ipc_channel_reader.h:9:0,
                 from ipc/ipc_channel_reader.cc:5:
./ipc/ipc_channel.h:184:22: error: ‘uid_t’ has not been declared
make: *** [out/Debug/obj.target/ipc/ipc/ipc_channel_reader.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from ipc/ipc_channel.cc:5:0:
./ipc/ipc_channel.h:184:22: error: ‘uid_t’ has not been declared
make: *** [out/Debug/obj.target/ipc/ipc/ipc_channel.o] Error 1
In file included from ./ipc/ipc_channel_posix.h:9:0,
                 from ipc/ipc_channel_posix.cc:5:
./ipc/ipc_channel.h:184:22: error: ‘uid_t’ has not been declared
ipc/ipc_channel_posix.cc: In member function ‘virtual IPC::internal::ChannelReader::ReadState IPC::Channel::ChannelImpl::ReadData(char*, int, int*)’:
ipc/ipc_channel_posix.cc:900:41: error: narrowing conversion of ‘buffer_len’ from ‘int’ to ‘size_t {aka unsigned int}’ inside { } is ill-formed in C++11 [-Werror=narrowing]
ipc/ipc_channel_posix.cc: At global scope:
ipc/ipc_channel_posix.cc:1151:6: error: prototype for ‘bool IPC::Channel::GetClientEuid(uid_t*) const’ does not match any in class ‘IPC::Channel’
In file included from ./ipc/ipc_channel_posix.h:9:0,
                 from ipc/ipc_channel_posix.cc:5:
./ipc/ipc_channel.h:184:8: error: candidate is: bool IPC::Channel::GetClientEuid(int*) const
cc1plus: all warnings being treated as errors
make: *** [out/Debug/obj.target/ipc/ipc/ipc_channel_posix.o] Error 1
~/codes/chromium/src/cef/tools

As I saw in the official chromium repository, most of these bugs were fixed in the upstream, should rogerwang /chromium be synced to a near version?

@zcbenz
Copy link
Contributor Author

zcbenz commented Aug 7, 2012

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant