Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature?] redis database password authentication #467

Open
urothis opened this issue Apr 21, 2019 · 0 comments · May be fixed by #1505
Open

[Feature?] redis database password authentication #467

urothis opened this issue Apr 21, 2019 · 0 comments · May be fixed by #1505
Assignees
@niv
Labels
RFE: plugin New feature or request

Comments

@urothis
Copy link
Contributor

urothis commented Apr 21, 2019

I discussed this with 🐈 @niv alittle today.

current problem

I need to be able to define the redis database password.

nwnx_redis is using a connection pool internally
need to add some mechanism to set up new connections serviced by the pool

a not fun workaround

there is no guarantee you get the same connection between two commands
and even if you set poolsize=1, if nwnx_redis reconnects you will lose the AUTH too

lightly discussed solution

   would need to add some mechanism to set up new connections serviced by the pool

I believe the best solution, for the end user, would be to pass the password via env.
@Daztek Daztek added the RFE: plugin New feature or request label Apr 25, 2019
@niv niv self-assigned this Apr 10, 2022
niv added a commit to niv/unified that referenced this issue Apr 10, 2022
@niv
redis: password authentication
3ea3ad2 
Fixes nwnxee#467
@niv niv linked a pull request Apr 10, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niv niv

Labels
RFE: plugin New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

redis: password authentication niv/unified
3 participants
@niv @urothis @Daztek