Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong fix of import warning #6

Closed
rintcius opened this issue Jan 23, 2017 · 3 comments
Closed

Wrong fix of import warning #6

rintcius opened this issue Jan 23, 2017 · 3 comments

Comments

@rintcius
Copy link
Contributor

First of all thanks for writing this! This comes in very handy for my lib (which contains generated purescript code)

I was running pulp build -- --censor-lib --json-errors 2>&1 | ps-suggest --apply on my lib here but one warning was not fixed properly: https://github.com/rintcius/purescript-mathbox/blob/master/src/Mathbox/Classes.purs#L150

It changes this line into:

import Mathbox.Class.Data.Voxel (JsVoxel, Voxel, VoxelG, mkVoxel, voxelToJs)Voxel

instead of

import Mathbox.Class.Data.Voxel (JsVoxel, Voxel, VoxelG, mkVoxel, voxelToJs)
@nwolverson
Copy link
Owner

Ah, compiler ranges are wrong at the end of files, maybe it's that. Can maybe special case this one

@nwolverson nwolverson added the bug label Jan 24, 2017
@rintcius
Copy link
Contributor Author

Ok - FYI I also thought it may have to do with EOF - I tried to workaround it by adding a comment at the end of the file though, but that still gave the same error.

@nwolverson
Copy link
Owner

I do believe the issue at end of files is resolved since the compiler's parser switch, hence closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants