-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accepted Shares calculation in History tab is wrong if using both GPU and ASIC #5
Comments
Hi there. The lastAcceptedShares dictionary uses absolute indexes for the devices. What makes you think that you have two devices with the same index? The specific code that stores the value in lastAcceptedShares is below and you can see it is using the index of the row in the grid: lastAcceptedShares[rowIndex] = deviceInformation.AcceptedShares; |
I have verified this in the debugger (using current GitHub master), and there is a bug in the display of accepted shares in the history tab, but it is not quite as I described it, both devices are listed with the number of shares of the first device (GPU), not the total of both. |
Thank you for the additional information. From your description I am assuming this is only an issue with USB devices, and that you are using a new version of bfgminer? Can you confirm? If that is the case, can you please (if possible) see if this issue happens with bfgminer 3.2.1 (instead of 3.3.0) or cgminer? If my hunch in correct this issue was introduced with new code specifically for bfgminer 3.3.0. Thanks in advance. |
Thanks again for reporting this. Just to confirm this issue is specific to bfgminer 3.3.0. It does not exist with bfgminer 3.2.1 or cgminer. It is due to recent changes to MultiMiner to deal with changes in bfgminer 3.3.0. This should be addressed now, specifically in commit 4379a8a |
The calculation of the accepted shares variable adds up shares for all devices with the same device index. However, if you have two different types of devices (in my example, a GPU and a BE), they are each device index 1, so the display shows that each of them have an accepted shares value that is actually the sum of both devices.
Example:
15/10/2013 00:15 15/10/2013 00:22 Megacoin MEC .00007879 .00007879 30 7.31 minutes #1
15/10/2013 00:15 15/10/2013 00:22 Bitcoin BTC 1 1 30 7.26 minutes #1
I think that lastAcceptedShares needs to be indexed on both device id and device kind.
The text was updated successfully, but these errors were encountered: